This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix too generous error detection in behaviour.rs #8717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
ordian
approved these changes
May 3, 2021
eskimor
approved these changes
May 3, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
jordy25519
pushed a commit
to cennznet/substrate
that referenced
this pull request
Sep 17, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8715
If we have two active connections, one being closed, and one where the remote has tried re-opening a substream, then this will currently produce an error, even though this is a completely correct state.
Fixed that.
As to why there is no test: as always, it's super hard to test this because, since this is an internal state machine, it's hard to actually figure out which states are correct and which are not, as hard as actually reading/writing the code.
paritytech/polkadot-sdk#544 should eventually help with testing.