Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add a readme about feature metered for sp-utils #8736

Merged
1 commit merged into from
May 5, 2021
Merged

Add a readme about feature metered for sp-utils #8736

1 commit merged into from
May 5, 2021

Conversation

kpp
Copy link
Contributor

@kpp kpp commented May 5, 2021

This PR adds a readme about feature metered for sp-utils.

@kpp kpp added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 5, 2021
@kpp kpp requested a review from gnunicorn May 5, 2021 12:47
@kpp kpp added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label May 5, 2021
bkchr
bkchr reviewed May 5, 2021
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be put into the lib.rs file. As these readmes are generated from the lib.rs files

@kpp
Copy link
Contributor Author

kpp commented May 5, 2021

As these readmes are generated from the lib.rs files

How? Where is the script?

@bkchr
Copy link
Member

bkchr commented May 5, 2021

At least it was done once. I would assume that this is done for every release. Nevertheless, it is still good to also have this in the official docs of the crate.

@kpp
Copy link
Contributor Author

kpp commented May 5, 2021

cargo-readme geterates the previous version of readme. I will fix it. However there is no CI job to check readmes...

@kpp kpp force-pushed the kpp-pritimives-utils-readme branch from 2345433 to 1f5288b Compare May 5, 2021 13:58
@kpp kpp force-pushed the kpp-pritimives-utils-readme branch from 1f5288b to 11e1cf5 Compare May 5, 2021 14:03
@bkchr
Copy link
Member

bkchr commented May 5, 2021

bot merge

@ghost
Copy link

ghost commented May 5, 2021

Trying merge.

@ghost
Copy link

ghost commented May 5, 2021

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@ghost ghost merged commit 37effc7 into master May 5, 2021
@ghost ghost deleted the kpp-pritimives-utils-readme branch May 5, 2021 15:33
nazar-pc pushed a commit to autonomys/substrate that referenced this pull request Aug 8, 2021
@kpp @nazar-pc
Add a readme about feature metered for sp-utils (paritytech#8736)
70504fa
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@gnunicorn gnunicorn Awaiting requested review from gnunicorn

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpp @bkchr