This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Introduce code_substitute
#8898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new field `code_substitute` into the chain spec. This can be used to substitute the on-chain wasm starting from a given block until there is another wasm on chain (determined through the `spec_version`). This can be used to fix broken on chain wasm runtimes.
bkchr
added
A0-please_review
bkchr
commented
May 24, 2021
| /// The given `wasm_code` will be used to substitute the on-chain wasm code from the given | ||
| /// block hash onwards. | ||
| #[serde(default)] | ||
| code_substitutes: HashMap<String, Bytes>, |
There was a problem hiding this comment.
In a future pr I would like to replace String with something that directly checks that we got here some hex value.
|
would be better if this were a simple code_hash -> alt_code_blob mapping. block number is easy to get wrong. |
|
This is using block hashes? |
andresilva
approved these changes
May 24, 2021
rphmeier
approved these changes
May 25, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit 
dvdplm
reviewed
May 28, 2021
Comment on lines
+194
to
+195
| /// Map of WASM runtime substitute starting at the child of the given block until the runtime | ||
| /// version doesn't match anymore. |
There was a problem hiding this comment.
It'd be good to point out that the wasm_runtime_overrides trumps the wasm_runtime_substitutes?
nazar-pc
pushed a commit
to autonomys/substrate
that referenced
this pull request
Aug 8, 2021
This introduces a new field `code_substitute` into the chain spec. This can be used to substitute the on-chain wasm starting from a given block until there is another wasm on chain (determined through the `spec_version`). This can be used to fix broken on chain wasm runtimes.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new field
code_substituteinto the chain spec. Thiscan be used to substitute the on-chain wasm starting from a given block
until there is another wasm on chain (determined through the
spec_version). This can be used to fix broken on chain wasm runtimes.polkadot companion: paritytech/polkadot#3093