This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Test restoring zeroed data #9011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
added
A0-please_review
|
Why is it important that the memory is an array and not only a single primitive? Shouldn't all zero initialized memory be located in the bss? I am asking because you only access a single element of the array. |
|
It's not important. I started with |
|
Can you switch to just using a primitive? Then it would be consistent with the non-BSS test. static mut MUTABLE_STATIC_BSS: u32 = 0; |
athei
approved these changes
Jun 13, 2021
|
bot merge |
|
Trying merge. |
|
Bot will approve on the behalf of @pepyakin, since they are a team lead, in an attempt to reach the minimum approval count |
ghost
approved these changes
Jun 15, 2021
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test similar to one we already had:
returns_mutable_static. This time is for zero-initialized memory.