Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Do not run pallet_ui test with conditional-storage feature #9122

Merged
2 commits merged into from
Jun 16, 2021
Merged

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Jun 16, 2021

Fix #9120

CI run test for frame-support-test with the feature conditional-storage and without.
For UI test this is not necessary, also we can't feature-gate the output of the UI test.

This PR prevent running UI test when conditional-compilation feature is activated.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jun 16, 2021
@gui1117 gui1117 added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 16, 2021
@gui1117 gui1117 changed the title Do not run pallet_ui test with conditional-compilation feature Do not run pallet_ui test with conditional-storage feature Jun 16, 2021
@gui1117 gui1117 requested a review from KiChjang June 16, 2021 08:41
@gui1117
Copy link
Contributor Author

gui1117 commented Jun 16, 2021

bot merge

@ghost
Copy link

ghost commented Jun 16, 2021

Trying merge.

@ghost ghost merged commit c3e9fcf into master Jun 16, 2021
@ghost ghost deleted the gui-fix-test branch June 16, 2021 09:09
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate flaky UI test case in storage_info_unsatisfied_nmap.rs
3 participants