This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
slots: slot lenience must take into account block proposal portion #9138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
This was referenced Jun 17, 2021
ordian
approved these changes
Jun 18, 2021
bkchr
approved these changes
Jun 19, 2021
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
andresilva
force-pushed
the
andre/fix-slot-lenience
branch
from
52a2524 to
7996a77
Compare
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slot lenience calculation was being done on the original slot duration without accounting for the block proposal portion. This PR fixes that and additionally adds a
max_block_proposal_slot_portionso that the block proposal duration is never exceeded regardless of the slot lenience.polkadot companion: paritytech/polkadot#3294