Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix some failing ui tests #9157

Merged
7 commits merged into from
Jun 21, 2021
Merged

fix some failing ui tests #9157

7 commits merged into from
Jun 21, 2021

Conversation

coriolinus
Copy link
Contributor

Right now these are failing on master: https://gitlab.parity.io/parity/substrate/-/jobs/977367

@coriolinus coriolinus added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 21, 2021
@coriolinus coriolinus self-assigned this Jun 21, 2021
@coriolinus
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Jun 21, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Jun 21, 2021

Merge aborted: Checks failed for 7b37222

@gui1117
Copy link
Contributor

gui1117 commented Jun 21, 2021

bot merge

@ghost
Copy link

ghost commented Jun 21, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Jun 21, 2021

Merge aborted: Checks failed for aa91b15

@coriolinus
Copy link
Contributor Author

I wonder if the test failures are related to differing rustc versions? The PR was generated with TRYBUILD=overwrite cargo test -p frame-support-test on rustc 1.53.0. Does anyone here know what rustc the gitlab runner uses?

@gui1117
Copy link
Contributor

gui1117 commented Jun 21, 2021

I wonder if the test failures are related to differing rustc versions? The PR was generated with TRYBUILD=overwrite cargo test -p frame-support-test on rustc 1.53.0. Does anyone here know what rustc the gitlab runner uses?

I think the PR would be successful if we rebuild the test for all UI test, some are not in frame-support-test, there is some in max-encoded-len and in sp-api-test, and maybe also some other

@coriolinus
Copy link
Contributor Author

Took a while to rebuild all tests, but we'll see if updating all the UI tests fixes them.

@coriolinus
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Jun 21, 2021

Waiting for commit status.

@coriolinus
Copy link
Contributor Author

bot cancel

@ghost ghost merged commit abbe24e into master Jun 21, 2021
@ghost ghost deleted the prgn-fix-storage_info_unsatisfied_nmap branch June 21, 2021 13:12
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@bkchr bkchr bkchr approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coriolinus @gui1117 @shawntabrizi @bkchr