Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

clippy fixes #9173

Merged
merged 3 commits into from
Jul 26, 2021
Merged

clippy fixes #9173

merged 3 commits into from
Jul 26, 2021

Conversation

gilescope
Copy link
Contributor

A few clippy fixes while I was reading the staking reward pallet code.

Nothing controversial in there I hope except I did replace some doc tabs with spaces.

@gilescope gilescope added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 22, 2021
@gilescope gilescope requested a review from kianenigma as a code owner June 22, 2021 14:48
@gilescope gilescope requested a review from seunlanlege June 23, 2021 09:35
gui1117
gui1117 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some notes on 2 changes, but I don't mind new syntax either.

Looks good to me

emostov
emostov approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, my one nit is just this #9173 (comment)

@gilescope gilescope merged commit bcd628c into paritytech:master Jul 26, 2021
@gilescope gilescope deleted the giles-staking-reward-clippy branch July 26, 2021 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@emostov emostov emostov approved these changes

@kianenigma kianenigma Awaiting requested review from kianenigma

@seunlanlege seunlanlege Awaiting requested review from seunlanlege

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilescope @gui1117 @emostov