Implement set_attribute & set_class_attribute nonfungibles trait functions for Uniques pallet

frame/uniques/src/functions.rs

@@ -18,7 +18,7 @@
 //! Various pieces of common functionality.
 
 use super::*;
-use frame_support::{ensure, traits::Get};
+use frame_support::{ensure, traits::Get, BoundedVec};
 use sp_runtime::{DispatchResult, DispatchError};
 
 impl<T: Config<I>, I: 'static> Pallet<T, I> {
@@ -112,4 +112,47 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> {
 		Self::deposit_event(Event::Burned(class, instance, owner));
 		Ok(())
 	}
+
+	pub(super) fn do_set_attribute(
+        class: T::ClassId,
+        maybe_instance: Option<T::InstanceId>,
+        maybe_check_owner: &Option<T::AccountId>,
+        key: BoundedVec<u8, T::KeyLimit>,
+        value: BoundedVec<u8, T::ValueLimit>,
+        with_details: impl FnOnce(&ClassDetailsFor<T, I>) -> DispatchResult,
+    ) -> DispatchResult {
+        let mut class_details = Class::<T, I>::get(&class).ok_or(Error::<T, I>::Unknown)?;
+        with_details(&class_details)?;
+
+        let maybe_is_frozen = match maybe_instance {
+            None => ClassMetadataOf::<T, I>::get(class).map(|v| v.is_frozen),
+            Some(instance) => InstanceMetadataOf::<T, I>::get(class, instance).map(|v| v.is_frozen),
+        };
+        ensure!(!maybe_is_frozen.unwrap_or(false), Error::<T, I>::Frozen);
+
+        let attribute = Attribute::<T, I>::get((class, maybe_instance, &key));
+        if attribute.is_none() {
+            class_details.attributes.saturating_inc();
+        }
+        let old_deposit = attribute.map_or(Zero::zero(), |m| m.1);
+        class_details.total_deposit.saturating_reduce(old_deposit);
+        let mut deposit = Zero::zero();
+        if !class_details.free_holding && maybe_check_owner.is_some() {
+            deposit = T::DepositPerByte::get()
+                .saturating_mul(((key.len() + value.len()) as u32).into())
+                .saturating_add(T::AttributeDepositBase::get());
+        }
+        class_details.total_deposit.saturating_accrue(deposit);
+        if deposit > old_deposit {
+            T::Currency::reserve(&class_details.owner, deposit - old_deposit)?;
+        } else if deposit < old_deposit {
+            T::Currency::unreserve(&class_details.owner, old_deposit - deposit);
+        }
+
+        Attribute::<T, I>::insert((&class, maybe_instance, &key), (&value, deposit));
+        Class::<T, I>::insert(class, &class_details);
+
+        Self::deposit_event(Event::AttributeSet(class, maybe_instance, key, value));
+        Ok(())
+    }
 }

frame/uniques/src/impl_nonfungibles.rs

@@ -18,7 +18,7 @@
 //! Implementations for `nonfungibles` traits.
 
 use super::*;
-use sp_std::convert::TryFrom;
+use sp_std::convert::{TryFrom, TryInto};
 use frame_support::traits::tokens::nonfungibles::{Inspect, Mutate, Transfer};
 use frame_support::BoundedSlice;
 use sp_runtime::DispatchResult;
@@ -95,6 +95,43 @@ impl<T: Config<I>, I: 'static> Mutate<<T as SystemConfig>::AccountId> for Pallet
 	fn burn_from(class: &Self::ClassId, instance: &Self::InstanceId) -> DispatchResult {
 		Self::do_burn(class.clone(), instance.clone(), |_, _| Ok(()))
 	}
+
+    fn set_attribute(
+        class: &Self::ClassId,
+        instance: &Self::InstanceId,
+        key: &[u8],
+        value: &[u8],
+    ) -> DispatchResult {
+        let bounded_key = key.to_vec().try_into().map_err(|_| Error::<T, I>::KeyUpperBoundExceeded)?;
+        let bounded_value = value.to_vec().try_into().map_err(|_| Error::<T, I>::ValueUpperBoundExceeded)?;
+
+        Self::do_set_attribute(
+            class.clone(),
+            Some(instance.clone()),
+            &None,
+            bounded_key,
+            bounded_value,
+            |_| Ok(()),
+        )
+    }
+
+ fn set_class_attribute(
+        class: &Self::ClassId,
+        key: &[u8],
+        value: &[u8],
+    ) -> DispatchResult {
+        let bounded_key = key.to_vec().try_into().map_err(|_| Error::<T, I>::KeyUpperBoundExceeded)?;
+        let bounded_value = value.to_vec().try_into().map_err(|_| Error::<T, I>::ValueUpperBoundExceeded)?;
+
+        Self::do_set_attribute(
+            class.clone(),
+            None,
+            &None,
+            bounded_key,
+            bounded_value,
+            |_| Ok(()),
+        )
+    }
 }
 
 impl<T: Config<I>, I: 'static> Transfer<T::AccountId> for Pallet<T, I> {

frame/uniques/src/lib.rs

@@ -266,6 +266,10 @@ pub mod pallet {
 		NoDelegate,
 		/// No approval exists that would allow the transfer.
 		Unapproved,
+		/// Attribute key upper bound exceeded.
+		KeyUpperBoundExceeded,
+		/// Attribute value upper bound exceeded.
+		ValueUpperBoundExceeded,
 	}
 
 	#[pallet::hooks]
@@ -927,52 +931,34 @@ pub mod pallet {
 		///
 		/// Weight: `O(1)`
 		#[pallet::weight(T::WeightInfo::set_attribute())]
-		pub fn set_attribute(
-			origin: OriginFor<T>,
-			#[pallet::compact] class: T::ClassId,
-			maybe_instance: Option<T::InstanceId>,
-			key: BoundedVec<u8, T::KeyLimit>,
-			value: BoundedVec<u8, T::ValueLimit>,
-		) -> DispatchResult {
-			let maybe_check_owner = T::ForceOrigin::try_origin(origin)
-				.map(|_| None)
-				.or_else(|origin| ensure_signed(origin).map(Some))?;
-
-			let mut class_details = Class::<T, I>::get(&class).ok_or(Error::<T, I>::Unknown)?;
-			if let Some(check_owner) = &maybe_check_owner {
-				ensure!(check_owner == &class_details.owner, Error::<T, I>::NoPermission);
-			}
-			let maybe_is_frozen = match maybe_instance {
-				None => ClassMetadataOf::<T, I>::get(class).map(|v| v.is_frozen),
-				Some(instance) =>
-					InstanceMetadataOf::<T, I>::get(class, instance).map(|v| v.is_frozen),
-			};
-			ensure!(!maybe_is_frozen.unwrap_or(false), Error::<T, I>::Frozen);
-
-			let attribute = Attribute::<T, I>::get((class, maybe_instance, &key));
-			if attribute.is_none() {
-				class_details.attributes.saturating_inc();
-			}
-			let old_deposit = attribute.map_or(Zero::zero(), |m| m.1);
-			class_details.total_deposit.saturating_reduce(old_deposit);
-			let mut deposit = Zero::zero();
-			if !class_details.free_holding && maybe_check_owner.is_some() {
-				deposit = T::DepositPerByte::get()
-					.saturating_mul(((key.len() + value.len()) as u32).into())
-					.saturating_add(T::AttributeDepositBase::get());
-			}
-			class_details.total_deposit.saturating_accrue(deposit);
-			if deposit > old_deposit {
-				T::Currency::reserve(&class_details.owner, deposit - old_deposit)?;
-			} else if deposit < old_deposit {
-				T::Currency::unreserve(&class_details.owner, old_deposit - deposit);
-			}
-
-			Attribute::<T, I>::insert((&class, maybe_instance, &key), (&value, deposit));
-			Class::<T, I>::insert(class, &class_details);
-			Self::deposit_event(Event::AttributeSet(class, maybe_instance, key, value));
-			Ok(())
-		}
+        pub fn set_attribute(
+            origin: OriginFor<T>,
+            #[pallet::compact] class: T::ClassId,
+            maybe_instance: Option<T::InstanceId>,
+            key: BoundedVec<u8, T::KeyLimit>,
+            value: BoundedVec<u8, T::ValueLimit>,
+        ) -> DispatchResult {
+            let maybe_check_owner = T::ForceOrigin::try_origin(origin)
+                .map(|_| None)
+                .or_else(|origin| ensure_signed(origin).map(Some))?;
+
+            Self::do_set_attribute(
+                class,
+                maybe_instance,
+                &maybe_check_owner,
+                key,
+                value,
+                |class_details| {
+                    if let Some(check_owner) = &maybe_check_owner {
+                        ensure!(
+                            check_owner == &class_details.owner,
+                            Error::<T, I>::NoPermission
+                        );
+                    }
+                    Ok(())
+                },
+            )
+        }
 
 		/// Set an attribute for an asset class or instance.
 		///