This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I didn't test this PR on the live network, since #900 broke the networking. |
I think the test got [dead]locked and has been running for 374 minutes 26 seconds, so I cancelled it. |
Just seems to keep hanging on this process node_service, taking all available cpu power:
|
460e1e5
to
6716835
Compare
What is missing to merge this pull request? Do you had any chance to test it @tomaka? |
c4aeec5
to
fccedab
Compare
#1062 successfully synced on my machine over night. |
@tomaka so we are good to go and we can merge this? Or do we need more testing? |
bkchr
approved these changes
Nov 5, 2018
Should be good in my opinion. |
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
* upsub * Revert branch change * Fix some * Fix build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Substrate code uses a fork of libp2p. Now that the changes from this fork have been merged into libp2p master, let's switch to this master branch.