Benchmarking also benchmark for decoding the call #9343

gui1117 · 2021-07-13T18:25:09Z

in the benchmarking macro, when user use the syntax: bench_name { $code }: $dispatch_name($origin, $args) verify { $code }, the benchmark only dispatch the call. This PR changes it, instead the benchmark decode the call and dispatch it.

Breaking change

Some benchmark code won't compile complaining about partially moved variables. It should be generally easily fixable using clone.

kianenigma · 2021-07-13T19:48:01Z

Sensible to have it IMO 👍🏻

shawntabrizi · 2021-07-13T20:05:47Z

I agree, if we are finding this is more and more relevant, we should definitely include it.

How can we add a test so that we know this is working as expected?

emostov · 2021-07-13T21:53:51Z

I agree, if we are finding this is more and more relevant, we should definitely include it.

Was there any specific rational for not including it before?

From my limited understanding it makes sense to always do this iff when processing the extrinsics in a block we always have to decode each one.

gui1117 · 2021-07-14T07:44:23Z

/benchmark runtime pallet pallet_lottery

parity-benchapp · 2021-07-14T07:44:25Z

Benchmark Runtime Pallet for branch "gui-benchmark-decoding" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Results

error[E0382]: use of partially moved value: `instance`
    --> frame/contracts/src/benchmarking/mod.rs:280:1
     |
280  | / benchmarks! {
281  | |     where_clause { where
282  | |         T::AccountId: UncheckedFrom<T::Hash>,
283  | |         T::AccountId: AsRef<[u8]>,
...    |
730  | |     }: call(origin, instance.addr, 0u32.into(), Weight::max_value(), vec![])
     | |                     ------------- value partially moved here
...    |
733  | |             assert_eq!(T::Currency::total_balance(&instance.account_id), 0u32.into());
     | |                                                    -------- use occurs due to use in closure
...    |
2532 | |     }: {}
2533 | | }
     | |_^ value used here after partial move
     |
     = note: partial move occurs because `instance.addr` has type `<<T as frame_system::Config>::Lookup as sp_runtime::traits::StaticLookup>::Source`, which does not implement the `Copy` trait
     = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to previous error

For more information about this error, try `rustc --explain E0382`.
error: could not compile `pallet-contracts`

To learn more, run the command again with --verbose.
error: build failed

… gui-benchmark-decoding

gui1117 · 2021-07-14T07:52:15Z

/benchmark runtime pallet pallet_lottery

parity-benchapp · 2021-07-14T07:52:16Z

Benchmark Runtime Pallet for branch "gui-benchmark-decoding" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Results

Pallet: "pallet_lottery", Extrinsic: "buy_ticket", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    74.85
              µs

Reads = 6
Writes = 4
Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    74.85
              µs

Reads = 6
Writes = 4
Pallet: "pallet_lottery", Extrinsic: "set_calls", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    15.68
    + n    0.264
              µs

Reads = 0 + (0 * n)
Writes = 1 + (0 * n)
Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    n   mean µs  sigma µs       %
    0     14.97     0.059    0.3%
    1     15.95     0.069    0.4%
    2      16.3     0.068    0.4%
    3     16.53     0.072    0.4%
    4     16.84     0.026    0.1%
    5     17.09     0.151    0.8%
    6     17.29     0.067    0.3%
    7     17.54      0.08    0.4%
    8     17.78     0.079    0.4%
    9     18.02     0.086    0.4%
   10     18.12     0.078    0.4%

Quality and confidence:
param     error
n         0.007

Model:
Time ~=    15.54
    + n    0.281
              µs

Reads = 0 + (0 * n)
Writes = 1 + (0 * n)
Pallet: "pallet_lottery", Extrinsic: "start_lottery", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=     58.9
              µs

Reads = 3
Writes = 3
Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=     58.9
              µs

Reads = 3
Writes = 3
Pallet: "pallet_lottery", Extrinsic: "stop_repeat", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    7.714
              µs

Reads = 1
Writes = 1
Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    7.714
              µs

Reads = 1
Writes = 1
Pallet: "pallet_lottery", Extrinsic: "on_initialize_end", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    117.4
              µs

Reads = 6
Writes = 4
Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    117.4
              µs

Reads = 6
Writes = 4
Pallet: "pallet_lottery", Extrinsic: "on_initialize_repeat", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=      123
              µs

Reads = 7
Writes = 5
Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=      123
              µs

Reads = 7
Writes = 5

…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs

gui1117 · 2021-07-14T07:58:18Z

/benchmark runtime pallet pallet_utility

parity-benchapp · 2021-07-14T07:58:19Z

Benchmark Runtime Pallet for branch "gui-benchmark-decoding" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_utility --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/utility/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Results

Pallet: "pallet_utility", Extrinsic: "batch", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.13
    + c    1.082
              µs

Reads = 0 + (0 * c)
Writes = 0 + (0 * c)
Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    0     13.95     0.103    0.7%
   20     38.18     0.073    0.1%
   40     61.12     0.122    0.1%
   60      79.7     0.082    0.1%
   80     107.4     0.118    0.1%
  100     125.7     0.061    0.0%
  120     144.5     0.082    0.0%
  140     180.8     0.137    0.0%
  160     199.1       0.1    0.0%
  180     217.6     0.128    0.0%
  200     235.9     0.082    0.0%
  220     254.5      0.07    0.0%
  240       273     0.101    0.0%
  260     326.6     0.201    0.0%
  280     344.9     0.081    0.0%
  300     363.5     0.185    0.0%
  320     363.8     0.216    0.0%
  340     382.5      0.16    0.0%
  360     400.7     0.185    0.0%
  380     419.3     0.147    0.0%
  400       490     0.201    0.0%
  420     473.2     0.296    0.0%
  440     491.8     0.231    0.0%
  460       510     0.225    0.0%
  480     528.8     0.437    0.0%
  500     549.4     4.822    0.8%
  520     582.7      0.22    0.0%
  540     600.7     0.227    0.0%
  560     619.5     0.249    0.0%
  580     637.6      0.47    0.0%
  600       658     5.849    0.8%
  620     694.1      0.23    0.0%
  640       712     0.379    0.0%
  660     730.8     0.332    0.0%
  680       749     0.212    0.0%
  700     770.7     8.672    1.1%
  720     803.7     0.238    0.0%
  740     822.2     0.725    0.0%
  760     842.5     4.635    0.5%
  780     862.3     8.511    0.9%
  800     876.7     0.858    0.0%
  820     912.2     0.897    0.0%
  840     930.5     1.239    0.1%
  860     954.9     10.99    1.1%
  880     967.5      1.16    0.1%
  900     986.4     0.411    0.0%
  920      1028     10.92    1.0%
  940      1041     4.681    0.4%
  960      1058     0.364    0.0%
  980      1076     0.889    0.0%
 1000      1100     10.12    0.9%

Quality and confidence:
param     error
c         0.001

Model:
Time ~=    20.77
    + c     1.08
              µs

Reads = 0 + (0 * c)
Writes = 0 + (0 * c)
Pallet: "pallet_utility", Extrinsic: "as_derivative", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    3.994
              µs

Reads = 0
Writes = 0
Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    3.994
              µs

Reads = 0
Writes = 0
Pallet: "pallet_utility", Extrinsic: "batch_all", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    19.16
    + c    1.508
              µs

Reads = 0 + (0 * c)
Writes = 0 + (0 * c)
Min Squares Analysis
========
-- Extrinsic Time --

Data points distribution:
    c   mean µs  sigma µs       %
    0      14.9     0.121    0.8%
   20     47.64     0.082    0.1%
   40      79.3     0.099    0.1%
   60     106.2     0.115    0.1%
   80     142.3     0.066    0.0%
  100     169.3     0.067    0.0%
  120     196.6     0.102    0.0%
  140     241.4     0.093    0.0%
  160     268.2      0.16    0.0%
  180     295.1     0.211    0.0%
  200     321.9     0.129    0.0%
  220       349     0.158    0.0%
  240     375.9     0.293    0.0%
  260       438     0.156    0.0%
  280     464.9     0.175    0.0%
  300     491.6     0.153    0.0%
  320       501      0.22    0.0%
  340       529     3.714    0.7%
  360     554.6     0.292    0.0%
  380     581.8     0.834    0.1%
  400       664     8.652    1.3%
  420     652.6      0.21    0.0%
  440     681.3     0.882    0.1%
  460     708.2     0.605    0.0%
  480     735.4     0.372    0.0%
  500     772.1     11.78    1.5%
  520     805.8     1.286    0.1%
  540     833.2     0.856    0.1%
  560     858.9     1.214    0.1%
  580     894.5     12.56    1.4%
  600     914.1     0.856    0.0%
  620     958.7     1.008    0.1%
  640     985.1     0.906    0.0%
  660      1021     12.78    1.2%
  680      1038      1.14    0.1%
  700      1067      5.12    0.4%
  720      1122     13.91    1.2%
  740      1139     8.026    0.7%
  760      1162     1.042    0.0%
  780      1190      0.95    0.0%
  800      1220     7.576    0.6%
  820      1269     10.84    0.8%
  840      1291      7.77    0.6%
  860      1315     1.298    0.0%
  880      1342     0.669    0.0%
  900      1373     9.434    0.6%
  920      1412     1.016    0.0%
  940      1441     4.249    0.2%
  960      1474     11.18    0.7%
  980      1494     1.468    0.0%
 1000      1527     9.688    0.6%

Quality and confidence:
param     error
c         0.001

Model:
Time ~=    22.18
    + c    1.506
              µs

Reads = 0 + (0 * c)
Writes = 0 + (0 * c)

…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_utility --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/utility/src/weights.rs --template=./.maintain/frame-weight-template.hbs

emostov

My macro literacy is not great, but from what I understand this makes sense.

Should we re-benchmark everything (including in polkadot) so when we make logic changes in the future they are based off a baseline that used the same benchmarking formula? Otherwise I would think all future benchmarks would be a bit high.

parity-benchapp · 2021-07-20T15:46:16Z

Benchmark Runtime Pallet for branch "gui-benchmark-decoding" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_mmr --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/mmr/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Results

error[E0433]: failed to resolve: use of undeclared crate or module `frame_system`
  --> frame/system/src/weights.rs:58:9
   |
58 | impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
   |         ^^^^^^^^^^^^ use of undeclared crate or module `frame_system`

error[E0433]: failed to resolve: use of undeclared crate or module `frame_system`
  --> frame/system/src/weights.rs:58:9
   |
58 | impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
   |         ^^^^^^^^^^^^ use of undeclared crate or module `frame_system`

error: aborting due to previous error

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
For more information about this error, try `rustc --explain E0433`.
error: could not compile `frame-system`

To learn more, run the command again with --verbose.
error: build failed

gui1117 · 2021-07-20T15:46:18Z

/benchmark runtime pallet pallet_lottery

parity-benchapp · 2021-07-20T15:46:20Z

Benchmark Runtime Pallet for branch "gui-benchmark-decoding" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_lottery --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/lottery/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Results

error[E0433]: failed to resolve: use of undeclared crate or module `frame_system`
  --> frame/system/src/weights.rs:58:9
   |
58 | impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
   |         ^^^^^^^^^^^^ use of undeclared crate or module `frame_system`

error[E0433]: failed to resolve: use of undeclared crate or module `frame_system`
  --> frame/system/src/weights.rs:58:9
   |
58 | impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
   |         ^^^^^^^^^^^^ use of undeclared crate or module `frame_system`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
error: could not compile `frame-system`

To learn more, run the command again with --verbose.
error: build failed

gui1117 · 2021-07-20T15:46:22Z

/benchmark runtime pallet pallet_gilt

parity-benchapp · 2021-07-20T15:46:24Z

Benchmark Runtime Pallet for branch "gui-benchmark-decoding" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_gilt --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/gilt/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Results

error[E0433]: failed to resolve: use of undeclared crate or module `frame_system`
  --> frame/system/src/weights.rs:58:9
   |
58 | impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
   |         ^^^^^^^^^^^^ use of undeclared crate or module `frame_system`

error[E0433]: failed to resolve: use of undeclared crate or module `frame_system`
  --> frame/system/src/weights.rs:58:9
   |
58 | impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
   |         ^^^^^^^^^^^^ use of undeclared crate or module `frame_system`

error: aborting due to previous error

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
For more information about this error, try `rustc --explain E0433`.
error: could not compile `frame-system`

To learn more, run the command again with --verbose.
error: build failed

gui1117 · 2021-07-20T15:46:28Z

/benchmark runtime pallet pallet_uniques

parity-benchapp · 2021-07-20T15:46:30Z

Benchmark Runtime Pallet for branch "gui-benchmark-decoding" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_uniques --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/uniques/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Results

error[E0433]: failed to resolve: use of undeclared crate or module `frame_system`
  --> frame/system/src/weights.rs:58:9
   |
58 | impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
   |         ^^^^^^^^^^^^ use of undeclared crate or module `frame_system`

error[E0433]: failed to resolve: use of undeclared crate or module `frame_system`
  --> frame/system/src/weights.rs:58:9
   |
58 | impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
   |         ^^^^^^^^^^^^ use of undeclared crate or module `frame_system`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
error: could not compile `frame-system`

To learn more, run the command again with --verbose.
error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
error: build failed

gui1117 · 2021-07-20T15:46:32Z

/benchmark runtime pallet pallet_transaction_storage

parity-benchapp · 2021-07-20T15:46:34Z

Benchmark Runtime Pallet for branch "gui-benchmark-decoding" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_transaction_storage --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/transaction-storage/src/weights.rs --template=./.maintain/frame-weight-template.hbs

Results

error[E0433]: failed to resolve: use of undeclared crate or module `frame_system`
  --> frame/system/src/weights.rs:58:9
   |
58 | impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
   |         ^^^^^^^^^^^^ use of undeclared crate or module `frame_system`

error[E0433]: failed to resolve: use of undeclared crate or module `frame_system`
  --> frame/system/src/weights.rs:58:9
   |
58 | impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
   |         ^^^^^^^^^^^^ use of undeclared crate or module `frame_system`

error: aborting due to previous error

error: aborting due to previous error

For more information about this error, try `rustc --explain E0433`.
For more information about this error, try `rustc --explain E0433`.
error: could not compile `frame-system`

To learn more, run the command again with --verbose.
error: build failed

…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=frame_system --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/system/src/weights.rs --template=./.maintain/frame-weight-template.hbs

frame/system/src/weights.rs

shawntabrizi · 2021-07-21T02:39:43Z

bot merge

ghost · 2021-07-21T02:39:47Z

Waiting for commit status.

ghost · 2021-07-21T03:06:38Z

Merge failed: "Required status check "continuous-integration/gitlab-check-polkadot-companion-build" is failing."

gui1117 · 2021-07-21T11:51:02Z

frame/system/src/weights.rs

 			.saturating_add(T::DbWeight::get().writes((1 as Weight).saturating_mul(p as Weight)))
 	}
 }

 // For backwards compatibility and tests
 impl WeightInfo for () {
-	fn remark(_b: u32, ) -> Weight {
-		(1_038_000 as Weight)


interesting the weight is now only factor of message length

gui1117 · 2021-07-21T12:00:56Z

polkadot build will be fixed by paritytech/polkadot#3507

kianenigma

LGTM

gui1117 · 2021-07-22T08:49:16Z

bot merge

ghost · 2021-07-22T08:49:20Z

Trying merge.

gui1117 · 2021-07-22T09:29:39Z

bot merge

ghost · 2021-07-22T09:29:43Z

Trying merge.

benchmark for decoding of call

775e863

gui1117 requested a review from shawntabrizi July 13, 2021 18:25

github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jul 13, 2021

gui1117 mentioned this pull request Jul 13, 2021

Optimize calls for utility and lottery #9339

Closed

better names

a09c41e

gui1117 marked this pull request as ready for review July 14, 2021 07:43

Parity Benchmarking Bot and others added 2 commits July 14, 2021 07:44

Merge branch 'master' of https://github.com/paritytech/substrate into…

27052d0

… gui-benchmark-decoding

fix benchmarks

0803857

gui1117 requested a review from athei as a code owner July 14, 2021 07:51

gui1117 mentioned this pull request Jul 14, 2021

Make benchmark take into account the cost of decoding the call #9349

Closed

emostov approved these changes Jul 15, 2021

View reviewed changes

shawntabrizi approved these changes Jul 16, 2021

View reviewed changes

shawntabrizi reviewed Jul 21, 2021

View reviewed changes

frame/system/src/weights.rs Outdated Show resolved Hide resolved

Update frame/system/src/weights.rs

524f5dd

gui1117 commented Jul 21, 2021

View reviewed changes

kianenigma approved these changes Jul 22, 2021

View reviewed changes

ghost merged commit fced297 into master Jul 22, 2021

ghost deleted the gui-benchmark-decoding branch July 22, 2021 09:29

xlc mentioned this pull request Jul 22, 2021

Rerun benchmark AcalaNetwork/Acala#1249

Closed

gui1117 mentioned this pull request Jul 22, 2021

WIP: rerun benchmarks #9413

Closed

34 tasks

github-actions bot mentioned this pull request Aug 24, 2021

Update substrate/polkadot/cumulus from v0.9.8 to v0.9.9 moonbeam-foundation/moonbeam#729

Closed

Centril mentioned this pull request Oct 28, 2021

Interesting in substrate since last time PolymeshAssociation/Polymesh#1151

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Benchmarking also benchmark for decoding the call #9343

Benchmarking also benchmark for decoding the call #9343

gui1117 commented Jul 13, 2021 •

edited

Loading

kianenigma commented Jul 13, 2021

shawntabrizi commented Jul 13, 2021

emostov commented Jul 13, 2021 •

edited

Loading

gui1117 commented Jul 14, 2021

parity-benchapp bot commented Jul 14, 2021 •

edited

Loading

gui1117 commented Jul 14, 2021

parity-benchapp bot commented Jul 14, 2021 •

edited

Loading

gui1117 commented Jul 14, 2021

parity-benchapp bot commented Jul 14, 2021 •

edited

Loading

emostov left a comment

parity-benchapp bot commented Jul 20, 2021 •

edited

Loading

gui1117 commented Jul 20, 2021

parity-benchapp bot commented Jul 20, 2021 •

edited

Loading

gui1117 commented Jul 20, 2021

parity-benchapp bot commented Jul 20, 2021 •

edited

Loading

gui1117 commented Jul 20, 2021

parity-benchapp bot commented Jul 20, 2021 •

edited

Loading

gui1117 commented Jul 20, 2021

parity-benchapp bot commented Jul 20, 2021 •

edited

Loading

shawntabrizi commented Jul 21, 2021

ghost commented Jul 21, 2021

ghost commented Jul 21, 2021

gui1117 Jul 21, 2021

gui1117 commented Jul 21, 2021

kianenigma left a comment

gui1117 commented Jul 22, 2021

ghost commented Jul 22, 2021

gui1117 commented Jul 22, 2021

ghost commented Jul 22, 2021

Benchmarking also benchmark for decoding the call #9343

Benchmarking also benchmark for decoding the call #9343

Conversation

gui1117 commented Jul 13, 2021 • edited Loading

Breaking change

kianenigma commented Jul 13, 2021

shawntabrizi commented Jul 13, 2021

emostov commented Jul 13, 2021 • edited Loading

gui1117 commented Jul 14, 2021

parity-benchapp bot commented Jul 14, 2021 • edited Loading

gui1117 commented Jul 14, 2021

parity-benchapp bot commented Jul 14, 2021 • edited Loading

gui1117 commented Jul 14, 2021

parity-benchapp bot commented Jul 14, 2021 • edited Loading

emostov left a comment

Choose a reason for hiding this comment

parity-benchapp bot commented Jul 20, 2021 • edited Loading

gui1117 commented Jul 20, 2021

parity-benchapp bot commented Jul 20, 2021 • edited Loading

gui1117 commented Jul 20, 2021

parity-benchapp bot commented Jul 20, 2021 • edited Loading

gui1117 commented Jul 20, 2021

parity-benchapp bot commented Jul 20, 2021 • edited Loading

gui1117 commented Jul 20, 2021

parity-benchapp bot commented Jul 20, 2021 • edited Loading

shawntabrizi commented Jul 21, 2021

ghost commented Jul 21, 2021

ghost commented Jul 21, 2021

gui1117 Jul 21, 2021

Choose a reason for hiding this comment

gui1117 commented Jul 21, 2021

kianenigma left a comment

Choose a reason for hiding this comment

gui1117 commented Jul 22, 2021

ghost commented Jul 22, 2021

gui1117 commented Jul 22, 2021

ghost commented Jul 22, 2021

gui1117 commented Jul 13, 2021 •

edited

Loading

emostov commented Jul 13, 2021 •

edited

Loading

parity-benchapp bot commented Jul 14, 2021 •

edited

Loading

parity-benchapp bot commented Jul 14, 2021 •

edited

Loading

parity-benchapp bot commented Jul 14, 2021 •

edited

Loading

parity-benchapp bot commented Jul 20, 2021 •

edited

Loading

parity-benchapp bot commented Jul 20, 2021 •

edited

Loading

parity-benchapp bot commented Jul 20, 2021 •

edited

Loading

parity-benchapp bot commented Jul 20, 2021 •

edited

Loading

parity-benchapp bot commented Jul 20, 2021 •

edited

Loading