This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove Prometheus metrics prefix #9543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
|
would this be ready for merging and rolling out? |
stale
bot
removed
the
A5-stale
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
|
Beep |
stale
bot
removed
the
A5-stale
bkchr
approved these changes
Nov 19, 2021
|
@tomaka this doesn't compile, otherwise we should be good to merge this. |
|
@tomaka does not compile 😬 |
|
(cargo fmt 🙈 ) |
|
bot merge |
|
Error: It's not possible to meet the minimal approval count of 1 in paritytech/polkadot#3623 |
seunlanlege
pushed a commit
to seunlanlege/substrate
that referenced
this pull request
Dec 17, 2021
* Remove Prometheus metrics prefix * Fix line widths * Missed some metrics * Fix CLI * Run rustfmt on modified files * Missing prefixes * Hopefully fix compilation * Rustfmt protocol.rs * Should compile now I guess * Rustfmt Co-authored-by: Bastian Köcher <info@kchr.de>
PierreBesson
added a commit
to PierreBesson/substrate
that referenced
this pull request
Jan 10, 2022
* match the `substrate_` metrics prefix instead of `polkadot_`, following changes in paritytech#9543
PierreBesson
added a commit
to PierreBesson/substrate
that referenced
this pull request
Jan 10, 2022
* match the `substrate_` metrics prefix in alerts instead of `polkadot_`, following changes in paritytech#9543 * remove the filtering on polkadot|kusama domain for NumberOfFileDescriptorsHigh alert
PierreBesson
added a commit
to PierreBesson/substrate
that referenced
this pull request
Jan 10, 2022
* match the `substrate_` metrics prefix instead of `polkadot_` in dashboards, following changes in paritytech#9543
This was referenced Jan 10, 2022
bkchr
pushed a commit
that referenced
this pull request
Feb 2, 2022
* .maintain/monitoring: Update substrate prometheus alert rules * match the `substrate_` metrics prefix in alerts instead of `polkadot_`, following changes in #9543 * remove the filtering on polkadot|kusama domain for NumberOfFileDescriptorsHigh alert * .maintain/monitoring: Update substrate Grafana dashboards * match the `substrate_` metrics prefix instead of `polkadot_` in dashboards, following changes in #9543 * .maintain/monitoring: make the NumberOfFileDescriptorsHigh alert only apply for metrics tagged with 'chain'
agryaznov
pushed a commit
to agryaznov/substrate
that referenced
this pull request
Feb 4, 2022
* .maintain/monitoring: Update substrate prometheus alert rules * match the `substrate_` metrics prefix in alerts instead of `polkadot_`, following changes in paritytech#9543 * remove the filtering on polkadot|kusama domain for NumberOfFileDescriptorsHigh alert * .maintain/monitoring: Update substrate Grafana dashboards * match the `substrate_` metrics prefix instead of `polkadot_` in dashboards, following changes in paritytech#9543 * .maintain/monitoring: make the NumberOfFileDescriptorsHigh alert only apply for metrics tagged with 'chain'
Wizdave97
pushed a commit
to ComposableFi/substrate
that referenced
this pull request
Feb 4, 2022
* .maintain/monitoring: Update substrate prometheus alert rules * match the `substrate_` metrics prefix in alerts instead of `polkadot_`, following changes in paritytech#9543 * remove the filtering on polkadot|kusama domain for NumberOfFileDescriptorsHigh alert * .maintain/monitoring: Update substrate Grafana dashboards * match the `substrate_` metrics prefix instead of `polkadot_` in dashboards, following changes in paritytech#9543 * .maintain/monitoring: make the NumberOfFileDescriptorsHigh alert only apply for metrics tagged with 'chain'
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Remove Prometheus metrics prefix * Fix line widths * Missed some metrics * Fix CLI * Run rustfmt on modified files * Missing prefixes * Hopefully fix compilation * Rustfmt protocol.rs * Should compile now I guess * Rustfmt Co-authored-by: Bastian Köcher <info@kchr.de>
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* .maintain/monitoring: Update substrate prometheus alert rules * match the `substrate_` metrics prefix in alerts instead of `polkadot_`, following changes in paritytech#9543 * remove the filtering on polkadot|kusama domain for NumberOfFileDescriptorsHigh alert * .maintain/monitoring: Update substrate Grafana dashboards * match the `substrate_` metrics prefix instead of `polkadot_` in dashboards, following changes in paritytech#9543 * .maintain/monitoring: make the NumberOfFileDescriptorsHigh alert only apply for metrics tagged with 'chain'
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Remove Prometheus metrics prefix * Fix line widths * Missed some metrics * Fix CLI * Run rustfmt on modified files * Missing prefixes * Hopefully fix compilation * Rustfmt protocol.rs * Should compile now I guess * Rustfmt Co-authored-by: Bastian Köcher <info@kchr.de>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* .maintain/monitoring: Update substrate prometheus alert rules * match the `substrate_` metrics prefix in alerts instead of `polkadot_`, following changes in paritytech#9543 * remove the filtering on polkadot|kusama domain for NumberOfFileDescriptorsHigh alert * .maintain/monitoring: Update substrate Grafana dashboards * match the `substrate_` metrics prefix instead of `polkadot_` in dashboards, following changes in paritytech#9543 * .maintain/monitoring: make the NumberOfFileDescriptorsHigh alert only apply for metrics tagged with 'chain'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The situation right now is that, at initialization, we call
Registry::new_custom(Some("substrate"), None), which automatically adds asubstrate_prefix in front of every single metric that we register.Polkadot, however, overwrites this
Registryby doingRegistry::new_custom(Some("polkadot"), None), meaning that, in Polkadot, all metrics, even the ones defined in Substrate, have thepolkadot_prefix.This causes a big issue: Grafana dashboards and alerts need to be created once for Polkadot nodes and once for all-Substrate-chains-except-Polkadot.
This PR modifies this system by removing the automatic metrics prefixing. Instead, I've manually added
substrate_in front of all the metrics registered in Substrate andpolkadot_in front of all the metrics registered in Polkadot. This matches the Prometheus good practices, which mention that libraries (Substrate is a library) can have their own prefix different from the binary.However, in order to make things easier for devops, this PR also adds an automatic
{chain="chain_id"}parameter behind every metric, wherechain_idis the chain id found in the chain spec (e.g. "polkadot" or "ksmcc3").polkadot companion: paritytech/polkadot#3623