add clippy to CI

.cargo/config.toml

@@ -0,0 +1,7 @@
+[target.'cfg(feature = "cargo-clippy")']
+rustflags = [
+ "-Aclippy::all",
+ "-Dclippy::correctness",
+ "-Aclippy::if-same-then-else",
+ "-Aclippy::clone-double-ref"
+]

.gitlab-ci.yml

@@ -311,7 +311,7 @@ cargo-deny:
  when: always
  paths:
  - deny.log
- # FIXME: Temorarily allow to fail.
+ # FIXME: Temporarily allow to fail.
  allow_failure: true
 
 cargo-fmt:
@@ -321,6 +321,14 @@ cargo-fmt:
  script:
  - cargo +nightly fmt --all -- --check
 
+cargo-clippy:
+ stage: test
+ <<: *docker-env
+ <<: *test-refs
+ script:
+ - SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo +nightly clippy
+ allow_failure: true
+
 cargo-check-benches:
  stage: test
  <<: *docker-env

client/executor/src/wasm_runtime.rs

@@ -304,7 +304,7 @@ pub fn create_wasm_runtime_with_code(
  //
  // We drop the cache_path here to silence warnings that cache_path is not used if
  // compiling without the `wasmtime` flag.
- drop(cache_path);
+ let _ = cache_path;
 
  sc_executor_wasmi::create_runtime(
  blob,

client/executor/wasmtime/src/instance_wrapper.rs

@@ -399,6 +399,7 @@ impl InstanceWrapper {
  /// See `[memory_as_slice]`. In addition to those requirements, since a mutable reference is
  /// returned it must be ensured that only one mutable and no shared references to memory exists
  /// at the same time.
+ #[allow(clippy::mut_from_ref)]
  unsafe fn memory_as_slice_mut(&self) -> &mut [u8] {
  let ptr = self.memory.data_ptr();
  let len = self.memory.data_size();

client/network/src/block_request_handler.rs

@@ -85,6 +85,7 @@ struct SeenRequestsKey<B: BlockT> {
  support_multiple_justifications: bool,
 }
 
+#[allow(clippy::derive_hash_xor_eq)]
 impl<B: BlockT> Hash for SeenRequestsKey<B> {
  fn hash<H: Hasher>(&self, state: &mut H) {
  self.peer.hash(state);

client/network/src/state_request_handler.rs

@@ -78,6 +78,7 @@ struct SeenRequestsKey<B: BlockT> {
  start: Vec<u8>,
 }
 
+#[allow(clippy::derive_hash_xor_eq)]
 impl<B: BlockT> Hash for SeenRequestsKey<B> {
  fn hash<H: Hasher>(&self, state: &mut H) {
  self.peer.hash(state);

shell.nix

@@ -5,7 +5,7 @@ let
  rev = "4a07484cf0e49047f82d83fd119acffbad3b235f";
  });
  nixpkgs = import <nixpkgs> { overlays = [ mozillaOverlay ]; };
- rust-nightly = with nixpkgs; ((rustChannelOf { date = "2021-07-06"; channel = "nightly"; }).rust.override {
+ rust-nightly = with nixpkgs; ((rustChannelOf { date = "2021-07-10"; channel = "nightly"; }).rust.override {
  extensions = [ "rust-src" ];
  targets = [ "wasm32-unknown-unknown" ];
  });