This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Pallet Assets: Create new asset classes from genesis config #9742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgeddes
changed the title
|
This seems fine, but you dont want to give any genesis balances? I would expect a vec of |
shawntabrizi
added
B0-silent
|
I agree, I'll add that too. Also for asset metadata. |
Improve error message Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Improve error message Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
shawntabrizi
approved these changes
Sep 30, 2021
|
@vgeddes please merge master. And follow the instructions below. |
|
/tip small |
|
Please fix the following problems before calling the tip bot again:
|
|
Awesome, thanks for the tip! I've merged in master and pasted my address in the PR description, as well as below: Polkadot address: 13qBjpFmDbf5vyumEcqpUji5V2iVzsZb6oN7d1qH7i2ZRHep |
|
/tip small |
|
A small tip was successfully submitted for vgeddes (13qBjpFmDbf5vyumEcqpUji5V2iVzsZb6oN7d1qH7i2ZRHep on polkadot). |
emostov
approved these changes
Sep 30, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Oct 2, 2021
* master: (67 commits) Downstream `node-template` pull (#9915) Implement core::fmt::Debug for BoundedVec (#9914) Quickly skip invalid transactions during block authorship. (#9789) Add SS58 prefix for Automata (#9805) Clean up sc-peerset (#9806) Test each benchmark case in own #[test] (#9860) Add build with docker section to README (#9792) Simple Trait to Inspect Metadata (#9893) Pallet Assets: Create new asset classes from genesis config (#9742) doc: subkey usage (#9905) Silence alert about large-statement-fetcher (#9882) Fix democracy on-initialize weight (#9890) Fix basic authorship flaky test (#9906) contracts: Add event field names (#9896) subkey readme update on install (#9900) add feature wasmtime-jitdump (#9871) Return `target_hash` for finality_target instead of an Option (#9867) Update wasmtime to 0.29.0 (#9552) Less sleeps (#9848) remove unidiomatic (#9895) ...
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows chain developers to create new asset classes via genesis config. This is useful for asset classes controlled by the by the root account of a parachain.
Currently the assets pallet requires that stakeholders create a new asset class via a dispatchable (presumably invoked via an extrinsic). This limits the utility of the assets pallets. Our parachain would like to create new asset classes via a loosely coupled trait, and/or via genesis config. This PR addresses the latter.
If you think this is the right approach, I can go ahead and create companion PRs for Statemint, etc in the Cumulus repo
Polkadot address: 13qBjpFmDbf5vyumEcqpUji5V2iVzsZb6oN7d1qH7i2ZRHep