This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Expose destroy witness in Uniques #9824
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
User @green-jay, please sign the CLA here. |
|
I think this is a better solution to this problem: #9844 If you agree, you can close this PR and we will complete the other. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
pallet_uniquesas a base NFT pallet and trying to extend it's functionality in our own pallet(pallet_nft: pallet_uniques)The problem arises when you try to destroy an NFT class from
pallet_nft. In order to do that you need DestroyWitness which holds the info for each class. There is crate visibility set for the pallet storage hence it is necessary to expose a function which provides this info.For testing purposes it is also solicited to have a constructor with public fields available.