You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, connecting to insecure http or ws endpoints is just as easy as connecting to secure https/wss once (via either the Subxt library or the CLI tool).
A suggestion from @uzeyirdestan (who has been looking at potential sexurity issues in Subxt) is to make it a more explicit action to "opt-in" to insecure connections.
So, let's define any HTTP/WS connection apart from to localhost/127.0.0.1 as insecure.
Given this, one option would be something like:
On the CLI tool, require an --allow-insecure flag to be allowed to make an insecure connection (else, it will be rejected), and
In the library, for OnlineClient, add a from_insecure_url which allows insecure URLs, and prevent them via from_url
In the library, for LightClient connections to URLs, have something like build_from_insecure_url to complement build_from_url.
The macro also allows fetching metadata from any URL via from_runtime_url, but that's already meant to be dev only, so just make sure we document that it should be avoided in general.
Have I missed any other places where we establish a connection?
The text was updated successfully, but these errors were encountered:
Currently, connecting to insecure
http
orws
endpoints is just as easy as connecting to securehttps
/wss
once (via either the Subxt library or the CLI tool).A suggestion from @uzeyirdestan (who has been looking at potential sexurity issues in Subxt) is to make it a more explicit action to "opt-in" to insecure connections.
So, let's define any HTTP/WS connection apart from to
localhost
/127.0.0.1
as insecure.Given this, one option would be something like:
--allow-insecure
flag to be allowed to make an insecure connection (else, it will be rejected), andOnlineClient
, add afrom_insecure_url
which allows insecure URLs, and prevent them viafrom_url
LightClient
connections to URLs, have something likebuild_from_insecure_url
to complementbuild_from_url
.from_runtime_url
, but that's already meant to be dev only, so just make sure we document that it should be avoided in general.Have I missed any other places where we establish a connection?
The text was updated successfully, but these errors were encountered: