-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make using insecure connections opt-in #1309
Merged
niklasad1
merged 20 commits into
master
from
tadeohepperle/make-insecure-connections-opt-in
Jan 9, 2024
Merged
Make using insecure connections opt-in #1309
niklasad1
merged 20 commits into
master
from
tadeohepperle/make-insecure-connections-opt-in
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
reviewed
Dec 5, 2023
lexnv
reviewed
Dec 5, 2023
niklasad1
reviewed
Jan 3, 2024
niklasad1
reviewed
Jan 4, 2024
niklasad1
reviewed
Jan 4, 2024
niklasad1
reviewed
Jan 4, 2024
niklasad1
reviewed
Jan 4, 2024
niklasad1
reviewed
Jan 4, 2024
niklasad1
reviewed
Jan 4, 2024
niklasad1
reviewed
Jan 4, 2024
niklasad1
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added some minor suggestions
This looks great! A couple of places left that this should probably also be added to:
|
jsdw
approved these changes
Jan 4, 2024
niklasad1
reviewed
Jan 9, 2024
niklasad1
reviewed
Jan 9, 2024
…ish ws:// connection at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1239
To use insecure (no SSL, ws:// or http:// connections) one now has to:
OnlineClient::from_insecure_url
when constructing an online clientLightClientBuilder::build_from_insecure_url
when creating a light client--allow-insecure
flag to most commands in the CLI toolNote: localhost is considered secure and does not need this opt in.