Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for incompatible call metadata #584

Closed
ascjones opened this issue Jun 23, 2022 · 1 comment · Fixed by #633
Closed

Better error message for incompatible call metadata #584

ascjones opened this issue Jun 23, 2022 · 1 comment · Fixed by #633

Comments

@ascjones
Copy link
Contributor

ascjones commented Jun 23, 2022

User reported an error with what looks like an incompatible call, for which we receive the following generic error message:

Node metadata is not fully compatible

From this error variant:

IncompatibleMetadata,
, raised here
Err(::subxt::MetadataError::IncompatibleMetadata.into())
.

What would be better is something with more context e.g:

Metadata for the "instantiate" call is incompatible with the target node or similar.

Possibly we already discussed this issue in the original PR but I can't find anything to link to.

@ascjones ascjones changed the title Better error message for incompatible call Better error message for incompatible call metadata Jun 23, 2022
@jsdw jsdw added this to the v0.23: Tidy and Polish milestone Jun 23, 2022
@jsdw
Copy link
Collaborator

jsdw commented Jun 23, 2022

I popped this in the next release milestone; seems like a small ergonomic win that would be good to get in!

In theory, it should be obvious from the code what call didn't work, so I think this is more useful for us when users report things then actually for users themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants