Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize incompatible metadata errors #633

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Specialize incompatible metadata errors #633

merged 1 commit into from
Aug 24, 2022

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Aug 23, 2022

This PR specializes the metadata errors to contain information
about the incompatible components, for static validation purposes.

Closes #584.

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv self-assigned this Aug 23, 2022
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! ❤️

Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop, nice!

@lexnv lexnv merged commit 798e3aa into master Aug 24, 2022
@lexnv lexnv deleted the 584_metadata_err branch August 24, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message for incompatible call metadata
4 participants