Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Write output to file #1018

Merged
merged 1 commit into from
Jun 16, 2023
Merged

cli: Write output to file #1018

merged 1 commit into from
Jun 16, 2023

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Jun 16, 2023

This PR adds the ability to output the result of the subxt/cli metadata command to a dedicated file.

This is in response to #969, where the output from the Windows process to the file results in metadata byte differences.

With this patch applied:

$> Get-FileHash .\win.scale

Algorithm       Hash                                                                   Path
---------       ----                                                                   ----
SHA256          637D22238919A0293847BB0DA3F4E3E3FCF0711AF07DE7BF3E8527437962E8BE       D:\subxt\cli\win.scale


$> shasum -a 256 mac.scale                                                     
637d22238919a0293847bb0da3f4e3e3fcf0711af07de7bf3e8527437962e8be  mac.scale

Closes #969

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv requested a review from a team as a code owner June 16, 2023 10:47
@lexnv lexnv self-assigned this Jun 16, 2023
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@lexnv lexnv merged commit d383470 into master Jun 16, 2023
@lexnv lexnv deleted the lexnv/fix_windows branch June 16, 2023 15:24
@jsdw jsdw mentioned this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for subxt-cli and windows.
3 participants