Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime API: Substitute UncheckedExtrinsic with custom encoding #1076

Merged
merged 20 commits into from
Jul 21, 2023
Merged

runtime API: Substitute UncheckedExtrinsic with custom encoding #1076

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2ad017f
codegen: Add uncheckedExtrinsic substitute
lexnv Jul 19, 2023
2468751
subxt: Add uncheckedExtrinsic replacement
lexnv Jul 19, 2023
8a81d75
testing: Test uncheckedExtrinsic encoding
lexnv Jul 19, 2023
7dad649
testing: Apply clippy
lexnv Jul 19, 2023
13151c7
subxt: Implement encode_to instead of encode for uncheckedExtrinsic
lexnv Jul 19, 2023
f5724e4
subxt: Remove encode_as_fields from uncheckedExtrinsic
lexnv Jul 19, 2023
dec4577
utils: Extend the UncheckedExtrinsic interface
lexnv Jul 19, 2023
06b2d53
utils: Use Static<Encoded> for uncheckedExtrinsic
lexnv Jul 19, 2023
c87b85a
utils: Remove extra impl on the uncheckedExtrinsic
lexnv Jul 19, 2023
3287d9a
utils: Add back the EncodeAsType
lexnv Jul 19, 2023
3447a26
utils: Simplify the decode_as_type
lexnv Jul 19, 2023
2d9a374
utils: Use encode_as_type
lexnv Jul 19, 2023
9345d0a
Merge remote-tracking branch 'origin/master' into lexnv/runtime_api_e…
lexnv Jul 20, 2023
d33104a
utils: impl Decode for UncheckedExtrinsic
lexnv Jul 20, 2023
9c07895
Update subxt/src/utils/unchecked_extrinsic.rs
lexnv Jul 20, 2023
55a3e99
utils: Apply cargo fmt
lexnv Jul 20, 2023
ac30a50
Merge branch 'master' into lexnv/runtime_api_extrinsic_encoding
lexnv Jul 20, 2023
c39f90b
utils: Check encoding / decoding of uncheckedExtrinsic
lexnv Jul 20, 2023
ff88a85
Merge remote-tracking branch 'origin/lexnv/runtime_api_extrinsic_enco…
lexnv Jul 20, 2023
43c1ff3
utils/tests: Use an already encoded tx bytes to start with
lexnv Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion subxt/src/utils/unchecked_extrinsic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use scale_decode::{visitor::DecodeAsTypeResult, DecodeAsType, IntoVisitor, Visit
use super::{Encoded, Static};

/// The unchecked extrinsic from substrate.
#[derive(Clone, Debug, Eq, PartialEq, Decode, Encode)]
#[derive(Clone, Debug, Eq, PartialEq, Encode)]
pub struct UncheckedExtrinsic<Address, Call, Signature, Extra>(
Static<Encoded>,
#[codec(skip)] PhantomData<(Address, Call, Signature, Extra)>,
Expand All @@ -35,6 +35,15 @@ impl<Address, Call, Signature, Extra> UncheckedExtrinsic<Address, Call, Signatur
}
}

impl<Address, Call, Signature, Extra> Decode
for UncheckedExtrinsic<Address, Call, Signature, Extra>
{
fn decode<I: codec::Input>(input: &mut I) -> Result<Self, codec::Error> {
let xt_vec: Vec<u8> = Decode::decode(input)?;
lexnv marked this conversation as resolved.
Show resolved Hide resolved
Ok(UncheckedExtrinsic::new(xt_vec))
}
}

impl<Address, Call, Signature, Extra> scale_encode::EncodeAsType
for UncheckedExtrinsic<Address, Call, Signature, Extra>
{
Expand Down