Bump to latest scale-encode/decode/value and fix test running #1103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests locally failed because we were still explicitly passing incorrect paths, so I fixed that. I also bumped versions of
scale-encode
,scale-decode
andscale-value
and fixed anything that broke as a result, and changed the CI to download tosubstrate-node
to mirror the changed binary name.One change that was spotted here in a failing test: previously,
scale_value::Value
's would each come with a type ID of the type they decoded from, and this could be used to re-encode the value in the same way. This is no longer always possible, because we now "skip" overCompact
types when decoding. It's a trade-off:I think this is fair enough; the Type IDs that are attached to values are meant to help with diagnostics and such more than anything, and values should be encoded, as other types, by providing a target type ID to aim them at.