Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chainHead: Propagate results on the chainHead_follow #1116

Merged
merged 11 commits into from
Aug 9, 2023

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Aug 9, 2023

After the change introduced in substrate paritytech/substrate#14692, the chainHead API propagates the response of chainHead_body, chainHead_call and chainHead_storage on the chainHead_follow subscription.

  • the chainHead related events are updated
  • storage related events are removed
  • chainHead_body, chainHead_call and chainHead_storage are now methods that return an operationId
  • chainHead_follow produces events with the result of methods identified by operationId

Closes #1115.

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv self-assigned this Aug 9, 2023
@lexnv lexnv requested a review from a team as a code owner August 9, 2023 11:15
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
subxt/src/rpc/types.rs Outdated Show resolved Hide resolved
subxt/src/rpc/types.rs Outdated Show resolved Hide resolved
subxt/src/rpc/types.rs Outdated Show resolved Hide resolved
subxt/src/rpc/types.rs Outdated Show resolved Hide resolved
subxt/src/rpc/types.rs Outdated Show resolved Hide resolved
subxt/src/rpc/types.rs Outdated Show resolved Hide resolved
lexnv and others added 5 commits August 9, 2023 15:56
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv merged commit b97acc5 into master Aug 9, 2023
8 checks passed
@lexnv lexnv deleted the lexnv/sync_chain_head branch August 9, 2023 14:40
@jsdw jsdw mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subxt integration tests failed against latest Substrate build.
3 participants