Batch fetching storage values again #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…figurable if that is needed enough
lexnv
approved these changes
Oct 9, 2023
tadeohepperle
approved these changes
Oct 9, 2023
niklasad1
approved these changes
Oct 10, 2023
|
Before I merge this I'll just see if its worth adding a test or something to make sure that the storage values returned are as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Backend trait was added, I moved to fetching storage values one by one because the batch function we used was a little confusing and it seemed simpler at the time.
This PR adds back the fetching of storage values in batches, and improves the docs on the relevant RPC methods to clarify their behaviour.
Closes #1195