Update smoldot to 0.12 #1212

lexnv · 2023-10-19T14:15:06Z

Update smoldot to 0.12 and smoldot-light to 0.10 to benefit from the latest updates and performance improvements.

This PR changes the SubxtPlatform implementation to align with the latest PlatformRef from smoldot.

A new module named with-buffers is added to facilitate the low-level implementation.

The module is added to ease the transition to the smoldot with-buffers, that at the moment is not compatible with wasm due to the std::time::Instant. Ideally, smoldot will provide support for these buffers and the said code could be entirely removed from subxt.

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

niklasad1 · 2023-10-19T14:55:14Z

Seems to some issue with the gloo-net version in the WASM tests...

lexnv · 2023-10-19T15:50:31Z

Yep the subxt implementation of the smoldot wasm-platform also needs some adjustment

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

…client

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

tadeohepperle

👍

niklasad1 · 2023-11-01T13:36:11Z

lightclient/src/platform/wasm_helpers.rs

+        ///
+        /// The socket must still be open in both directions.
+        pub fn new(socket: T) -> Self {
+            let read_buffer_reasonable_capacity = 65536; // TODO: make configurable?


could be a constant

lightclient/src/platform/wasm_helpers.rs

lightclient/src/platform/wasm_platform.rs

jsdw

Nice! (I'm assuming the with_buffer module is basically copied and will go away, which will be lovely and really simplify things!)

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv · 2023-11-03T11:35:33Z

Indeed, the with_buffer module will go away with the next smoldot deployment (which should include smol-dot/smoldot#1250). For the meanwhile, our with_buffer module is a close copy of smoldot.

Thanks for the reviews!

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

…client Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Update lightclient Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * testing: Fix typo Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * testing: Update cargo.toml Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Add tracing logs to improve debugging Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Add socket buffers module for `PlatformRef` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Update `SubxtPlatform` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * cargo: Add lightclient dependencies Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Update cargo.lock of wasm tests Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Add constant for with-buffer module Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Replace rand crate with getrandom Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * example: Update cargo lock file Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * examples: Update deps Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: Tadeo Hepperle <62739623+tadeohepperle@users.noreply.github.com>

* skeleton commit * signed extension decoding * fix some minor things * make api more similar to Extrinsics * defer decoding of signed extensions * fix byte slices * add test for nonce signed extension * adjust test and extend for tip * clippy * support both ChargeTransactionPayment and ChargeAssetTxPayment * address PR comments * Extend lifetimes, expose pub structs, remove as_type * add signed extensions to block subscribing example * add Decoded type * fix merging bug and tests * add decoded type in CustomSignedExtension * fix minor issues, extend test * cargo fmt differences * remove the `decoded` function * new as_signed_extra fn, do not expose as_type anymore * fix Result-Option order, simplify obtaining Nonce * tx: Remove `wait_for_in_block` helper method (#1237) Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Update smoldot to 0.12 (#1212) * Update lightclient Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * testing: Fix typo Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * testing: Update cargo.toml Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Add tracing logs to improve debugging Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Add socket buffers module for `PlatformRef` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Update `SubxtPlatform` Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * cargo: Add lightclient dependencies Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * Update cargo.lock of wasm tests Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Add constant for with-buffer module Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * lightclient: Replace rand crate with getrandom Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * example: Update cargo lock file Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * examples: Update deps Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: Tadeo Hepperle <62739623+tadeohepperle@users.noreply.github.com> * ChargeAssetTxPayment: support providing u32 or MultiLocation in default impl (#1227) * Asset Id in Config trait * add example configuring the config * fmt * fix Default trait bound * merge examples, fix default again * adjust config in examples * Update subxt/src/config/mod.rs Co-authored-by: James Wilson <james@jsdw.me> --------- Co-authored-by: James Wilson <james@jsdw.me> * generic AssetId * fix generics * fmt --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> Co-authored-by: James Wilson <james@jsdw.me> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>

Update lightclient

d411987

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv requested a review from a team as a code owner October 19, 2023 14:15

lexnv added 8 commits October 27, 2023 14:54

testing: Fix typo

c11ca4d

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

testing: Update cargo.toml

212f8ab

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient: Add tracing logs to improve debugging

fec50e4

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient: Add socket buffers module for PlatformRef

b07c3a8

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient: Update SubxtPlatform

409c54d

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

cargo: Add lightclient dependencies

67429d4

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Merge remote-tracking branch 'origin/master' into lexnv/update-light-…

87515d4

…client

Update cargo.lock of wasm tests

121b475

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv mentioned this pull request Oct 27, 2023

Generalize libp2p::with_buffers for wasm environments smol-dot/smoldot#1250

Merged

Merge branch 'master' into lexnv/update-light-client

5c02b43

tadeohepperle approved these changes Oct 30, 2023

View reviewed changes

niklasad1 reviewed Nov 1, 2023

View reviewed changes

lightclient/src/platform/wasm_helpers.rs Outdated Show resolved Hide resolved

niklasad1 reviewed Nov 1, 2023

View reviewed changes

lightclient/src/platform/wasm_helpers.rs Show resolved Hide resolved

niklasad1 approved these changes Nov 1, 2023

View reviewed changes

jsdw reviewed Nov 1, 2023

View reviewed changes

lightclient/src/platform/wasm_helpers.rs Show resolved Hide resolved

jsdw reviewed Nov 1, 2023

View reviewed changes

lightclient/src/platform/wasm_platform.rs Outdated Show resolved Hide resolved

jsdw approved these changes Nov 1, 2023

View reviewed changes

lexnv added 2 commits November 3, 2023 13:03

lightclient: Add constant for with-buffer module

999b6d0

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient: Replace rand crate with getrandom

7dd463c

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv added 3 commits November 3, 2023 13:59

example: Update cargo lock file

49a5d2d

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Merge remote-tracking branch 'origin/master' into lexnv/update-light-…

b2c79f0

…client Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

examples: Update deps

89cc497

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lexnv merged commit b472fe5 into master Nov 3, 2023
10 checks passed

lexnv deleted the lexnv/update-light-client branch November 3, 2023 13:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update smoldot to 0.12 #1212

Update smoldot to 0.12 #1212

lexnv commented Oct 19, 2023 •

edited

Loading

niklasad1 commented Oct 19, 2023

lexnv commented Oct 19, 2023

tadeohepperle left a comment

niklasad1 Nov 1, 2023

jsdw left a comment •

edited

Loading

lexnv commented Nov 3, 2023

Update smoldot to 0.12 #1212

Update smoldot to 0.12 #1212

Conversation

lexnv commented Oct 19, 2023 • edited Loading

niklasad1 commented Oct 19, 2023

lexnv commented Oct 19, 2023

tadeohepperle left a comment

Choose a reason for hiding this comment

niklasad1 Nov 1, 2023

Choose a reason for hiding this comment

jsdw left a comment • edited Loading

Choose a reason for hiding this comment

lexnv commented Nov 3, 2023

lexnv commented Oct 19, 2023 •

edited

Loading

jsdw left a comment •

edited

Loading