Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in proc-macro's. #123

Merged
merged 10 commits into from
Jun 22, 2020

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented Jun 20, 2020

@dvc94ch dvc94ch force-pushed the proc-macro-error branch from 542eedd to dfc8161 Compare June 20, 2020 11:07
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Preferably split PRs like this into separate ones for distinct changesets, e.g. 1 for the macro error handling, another for the DispatchError handling etc.

@ascjones ascjones merged commit 3080ec9 into paritytech:master Jun 22, 2020
@ascjones ascjones mentioned this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants