storage: Fix partial key storage iteration #1298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the partial key storage iteration.
The storage key constructed by partial inputs was converted to the root storage key entry.
This meant that any partial input parameters provided to the key were completely ignored; and resulted in a wrongful behavior of iterating over all storage entries, rather than just the ones starting with the partial key.
To mitigate this behavior, the address bytes take into account the provided parameter inputs.
This loosens the expectations of
utils::storage_address_bytes
, which now only returns errors if the provided input types exceed the number of types from the metadata. Before this PR, the function expected an identical match in terms of the number of inputs.Testing Done
Closes: #1251