Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to substrate rc4 release #131

Merged
merged 9 commits into from
Jun 29, 2020
Merged

Upgrade to substrate rc4 release #131

merged 9 commits into from
Jun 29, 2020

Conversation

ascjones
Copy link
Contributor

No description provided.

@ascjones
Copy link
Contributor Author

Oddly I get the following test failure on CI, but not locally:

thread 'tests::test_create_raw_payload' panicked at 'assertion failed: `(left == right)`
  left: `MultiSignature::Ed25519(6dca736b575203dc2be429517559b797d157b2d20fd84d2e020b1c730c9ff6ffd6eaa6a40e20d57ebc2d559b3f06ca00477285ef7db6db10cb00a40ea5a5d600)`,
 right: `MultiSignature::Ed25519(be05d545cbe318283fd6df621041dcda51c8675b3e79d4fe5e63822f7c01b36546d862e0e378d08a783d38f6efb13f574940465414067c0177d69f972af17f09)`', src/lib.rs:611:9

@dvc94ch any ideas? #130 does touch this but can't see how it would break it.

@dvc94ch
Copy link
Contributor

dvc94ch commented Jun 26, 2020

I guess you could revert and push to this branch to see if it fixes it

@ascjones
Copy link
Contributor Author

ascjones commented Jun 26, 2020

Good idea I'll try that

Edit: except #130 was not even on this branch - just merged it in 😬

@dvc94ch
Copy link
Contributor

dvc94ch commented Jun 26, 2020

So here's one issue:

diff --git a/src/lib.rs b/src/lib.rs
index ae28b40..bce4734 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -578,7 +578,7 @@ mod tests {
 
         // create raw payload with AccoundId and sign it
         let raw_payload = client
-            .create_unsigned(
+            .create_payload(
                 balances::TransferCall {
                     to: &dest,
                     amount: 10_000,

But since you had it before I expect there to be another one.

With this change it works locally for me

@ascjones
Copy link
Contributor Author

Thanks that fixed it @dvc94ch

@ascjones ascjones merged commit d3e9e3f into master Jun 29, 2020
@ascjones ascjones deleted the aj-substrate-rc4 branch June 29, 2020 08:32
@dvc94ch
Copy link
Contributor

dvc94ch commented Jun 29, 2020

Can you release a new version of the client too? 0.10.0 doesn't build with the client feature enabled...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants