Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ExtrinsicDetails alongside decoded static extrinsics #1376

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

tadeohepperle
Copy link
Contributor

@tadeohepperle tadeohepperle commented Jan 18, 2024

fixes #1359

We introduce a new wrapper type around a static extrinsic of typeE that contains details about the extrinsic (e.g. signature, signed extensions, original bytes, metadata...)

pub struct FoundExtrinsic<T: Client, C, E> {
    pub details: ExtrinsicDetails,
    pub value: E
}

@tadeohepperle tadeohepperle requested a review from a team as a code owner January 18, 2024 11:05
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!

I'm surprised no book/examples needed changing; something to look at quickly maybe just to see that the example docs etc still make sense (clearly none were actually using the decoded extrinsic since no errors), but can be done separately!

@tadeohepperle
Copy link
Contributor Author

I'm surprised no book/examples needed changing

Not anymore! Since I just merged the PR with the additional examples to master, this PR now also needed an adjustment :)

@tadeohepperle tadeohepperle merged commit 6b065eb into master Jan 18, 2024
11 checks passed
@tadeohepperle tadeohepperle deleted the tadeohepperle/static-extrinsic-details branch January 18, 2024 16:30
@jsdw
Copy link
Collaborator

jsdw commented Jan 18, 2024

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access to Signed Extensions and Events when looking for a StaticExtrinsic
3 participants