Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Return error on wrongly specified type paths #1397

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

tadeohepperle
Copy link
Contributor

Fixes #1380

The CLI tool now reports misspecified type paths for the codegen attributes derive-for-type, attributes-for-type and substitute-type. In case another type with the same name is found in the metadata the user is provided with that information.

image

@tadeohepperle tadeohepperle requested a review from a team as a code owner January 25, 2024 09:15
Copy link
Collaborator

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, LGTM

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
@tadeohepperle tadeohepperle merged commit 4408a8c into master Jan 26, 2024
11 checks passed
@tadeohepperle tadeohepperle deleted the tadeohepperle/cli-derives-error-messages branch January 26, 2024 11:27
@jsdw jsdw mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI tool: Error on misspecified derives, attributes and substitutes
3 participants