Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Update smoldot to the latest version #1400
chore(deps): Update smoldot to the latest version #1400
Changes from 29 commits
bf3c7f3
1231920
ab0f67f
b948044
f14bf9a
644626f
b91742a
75ace42
c8020c9
6c9088e
74dd9d7
1c96d5e
03c629a
1de5a06
c74e4ad
b517adf
67ca3ec
c776229
c4fe110
6cca6f9
2e7bacd
c587309
a6d7055
3412cb6
b6bdd06
2779faf
4612da3
648b4f9
3b81de0
b69cba7
f222db1
1a02662
f3c6179
8b34dcd
30c81b8
7a41bf7
0b611f5
43bd4db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to worry about invalid UTF boundaries here too?
(should
trim_repsonse
take in a max length and then it can be used here too?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, you could actually index into non-char boundary here because not all chars are ascii which leads to a panic..
https://github.com/paritytech/jsonrpsee/blob/master/core/src/tracing.rs#L101-#L124
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of nightly only methods that would be perfect here, but in the absense of them one could do:
To find the appropriate place to slice a message that exceeds the length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've ended up with something similar to Niklas's suggestion, I found that a bit easier to follow :D