Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.13 #175

Merged
merged 14 commits into from
Oct 5, 2020
Merged

Release v0.13 #175

merged 14 commits into from
Oct 5, 2020

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Sep 24, 2020 •
edited
Loading

Based on #173 – only 1c3cf61 is new here.

Version 0.13.0

  • Update to Substrate 2.0.0 #173
  • Display RawEvent data in hex #168
  • Add SudoUncheckedWeightCall #167
  • Add Add SetCodeWithoutChecksCall #166
  • Improve contracts pallet tests #163
  • Make Metadata types public #162
  • Fix option decoding and add basic sanity test #161
  • Add staking support #160
  • Decode option event arg #158

@dvdplm dvdplm requested a review from ascjones September 24, 2020 09:59
ascjones
ascjones approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs master merging.

@DemiMarie
Copy link
Contributor

The integration tests fail for me. I am checking if this is due to an outdated Polkadot.

DemiMarie
DemiMarie reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@DemiMarie DemiMarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#172 needs to be merged first.

test-node/runtime/src/lib.rs Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
dvdplm and others added 4 commits September 25, 2020 10:22
@dvdplm @DemiMarie
Update test-node/runtime/src/lib.rs
9eb7626 
Co-authored-by: Demi Marie Obenour <demiobenour@gmail.com>
@dvdplm
Merge branch 'master' into dp-prep-release-v0.13
5f716f5 
* master:
  Remove unnecessary Sync requirements (#172)
@dvdplm
Merge branch 'dp-prep-release-v0.13' of github.com:paritytech/substra…
0856fff 
…te-subxt into dp-prep-release-v0.13

* 'dp-prep-release-v0.13' of github.com:paritytech/substrate-subxt:
  Update test-node/runtime/src/lib.rs
@dvdplm @DemiMarie
Update CHANGELOG.md
0344f06 
Co-authored-by: Demi Marie Obenour <demiobenour@gmail.com>
@dvdplm
Copy link
Contributor Author

dvdplm commented Sep 25, 2020

The integration tests fail for me. I am checking if this is due to an outdated Polkadot.

Can you be more specific? All of them? How did you run them? One by one? All at once? Which node type did you try and how did you start it, full command?

@DemiMarie
Copy link
Contributor

DemiMarie commented Sep 25, 2020 via email •
edited
Loading

@DemiMarie
Copy link
Contributor

@ascjones @dvdplm this cannot be merged until the blockchain has updated to the latest metadata.

@dvc94ch
Copy link
Contributor

dvc94ch commented Sep 27, 2020

Don't follow. Which chain do you mean? Polkadot, kusama, edgeware, sunshine or some other chain?

@DemiMarie
Copy link
Contributor

@dvc94ch Polkadot and Kusama

@dvc94ch
Copy link
Contributor

dvc94ch commented Sep 28, 2020

So are they guaranteed to be updated at the same time? I don't see what the deployment has to do with merging this pr. If you want to treat those chains specially, you can add branches for them, but really it's the responsibility of people building with subxt for a specific chain to make sure they have a combination that works.

@ascjones
Copy link
Contributor

ascjones commented Sep 28, 2020 •
edited
Loading

@ascjones @dvdplm this cannot be merged until the blockchain has updated to the latest metadata.

I don't think it's blocker, we don't need our releases to be in sync with what is deployed on any particular chain. We will make releases which are compatible with new versions of substrate as they come along, and people will choose whichever release matches their target chain.

This will be better now substrate has proper versioning (no longer pre-release), so we can track them.

@dvdplm
Copy link
Contributor Author

dvdplm commented Sep 28, 2020

I don't think it's blocker,

Yeah, my bad. I had ledgeracio in mind here, not subxt.

@ascjones
Copy link
Contributor

I don't know when the upgrade for substrate 2.0 is planned for kusama/polkadot, but it surely is soon.

In the meantime you could always craft an intermediate release with *-rc6 + Staking which would allow you to release ledgeracio if that is urgent.

@dvdplm dvdplm mentioned this pull request Sep 29, 2020
Closed
@dvdplm dvdplm marked this pull request as ready for review October 5, 2020 08:35
@dvdplm dvdplm merged commit fc2da6b into master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DemiMarie DemiMarie DemiMarie left review comments

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dvdplm @DemiMarie @dvc94ch @ascjones