Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decode DispatchInfo on ExtrinsicFailed events #189

Merged
merged 1 commit into from
Nov 13, 2020
Merged

decode DispatchInfo on ExtrinsicFailed events #189

merged 1 commit into from
Nov 13, 2020

Conversation

gregdhill
Copy link
Contributor

@gregdhill gregdhill commented Nov 5, 2020 •
edited
Loading

Signed-off-by: Gregory Hill gregorydhill@outlook.com

Closes #186

@gregdhill gregdhill force-pushed the decode-extrinsic-failed branch from eba9fbf to 947a1a3 Compare November 5, 2020 15:21
ascjones
ascjones reviewed Nov 5, 2020
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Before merging this I need to check what the status of our CLA bot is.

Also could you please include a short description of the bug as you describe in #186

src/events.rs Show resolved Hide resolved
src/events.rs Show resolved Hide resolved
src/events.rs Show resolved Hide resolved
@gregdhill
propagate 'RuntimeError's to 'decode_raw_bytes' caller
9d0b60c 
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
@gregdhill gregdhill force-pushed the decode-extrinsic-failed branch from 947a1a3 to 9d0b60c Compare November 5, 2020 20:02
@gregdhill
Copy link
Contributor Author

@ascjones I added a comment here. Let me know if I should note the issue elsewhere.

ascjones
ascjones approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting to hear about the CLA from @kirushik before I merge.

@gregdhill
Copy link
Contributor Author

@ascjones can this be merged yet?

@ascjones
Copy link
Contributor

Just got the go ahead from @kirushik.

@ascjones ascjones merged commit 27c377a into paritytech:master Nov 13, 2020
@gregdhill gregdhill deleted the decode-extrinsic-failed branch November 13, 2020 18:39
@ascjones ascjones mentioned this pull request Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concurrent calls return Scale codec error: No such variant in enum Phase
2 participants
@gregdhill @ascjones