Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Balances Locks #197

Merged
merged 9 commits into from
Jan 15, 2021
Merged

Add Balances Locks #197

merged 9 commits into from
Jan 15, 2021

Conversation

liuchengxu
Copy link
Contributor

No description provided.

@liuchengxu
Copy link
Contributor Author

Ping @ascjones

ascjones
ascjones reviewed Jan 12, 2021
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Could you add a simple test? See the tests module at the bottom of the file.

@liuchengxu
Merge branch 'master' of https://github.com/paritytech/substrate-subxt …
9446bf0 
…into add-balances-locks
@liuchengxu
Add tests for Balances Locks
c652eec 
In order to write this test, I just added the new staking::BondCall :).
@liuchengxu
Copy link
Contributor Author

@ascjones Test added, and added BondCall for writing this test:(, I have run the tests successfully locally.

ascjones
ascjones approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you merge master now it should fix the CI and we can get this merged

@ascjones ascjones merged commit 5a0201c into paritytech:master Jan 15, 2021
@ascjones ascjones mentioned this pull request Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuchengxu @ascjones