Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc client methods should be public for downstream usage #240

Merged
merged 1 commit into from
Mar 8, 2021
Merged

rpc client methods should be public for downstream usage #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/rpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ pub enum RpcClient {
}

impl RpcClient {
async fn request<T: DeserializeOwned>(
pub async fn request<T: DeserializeOwned>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some doc comments on these, which is why the CI is failing

&self,
method: &str,
params: Params,
Expand All @@ -186,7 +186,7 @@ impl RpcClient {
}
}

async fn subscribe<T: DeserializeOwned>(
pub async fn subscribe<T: DeserializeOwned>(
&self,
subscribe_method: &str,
params: Params,
Expand Down