Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: also processess initialize and finalize events in event subscription #321

Merged

Conversation

sander2
Copy link
Contributor

@sander2 sander2 commented Nov 12, 2021

Supersedes #283. It's modified based on your comment there and it's included in the unit test

Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me; thank you!

@sander2
Copy link
Contributor Author

sander2 commented Nov 19, 2021

@ascjones (or anyone else) just a ping - could you review/merge?

Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course I had forgotten that we need 2 reviews now.

Thanks!

@ascjones ascjones merged commit a701d80 into paritytech:master Nov 19, 2021
0623forbidden pushed a commit to DEIPworld/substrate-subxt that referenced this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants