Check docs and run clippy on PRs #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
approved these changes
Nov 18, 2021
niklasad1
reviewed
Nov 18, 2021
.github/workflows/rust.yml
Outdated
| uses: actions-rs/cargo@v1 | ||
| with: | ||
| command: clippy | ||
| args: -- -D warnings |
There was a problem hiding this comment.
all targets?!
Suggested change
| args: -- -D warnings | |
| args: --all-targets -- -D warnings |
There was a problem hiding this comment.
Ooh good catch! That picked up some more lint issues to fix too :D :'(
There was a problem hiding this comment.
maybe postpone it to another PR I suspect that it will require plenty of work :(
There was a problem hiding this comment.
Oh, I've just finished fixing them so it's all gravy :)
niklasad1
approved these changes
Nov 18, 2021
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
* Check docs, clippy, test run * test parallel CI adapted from other package; is it faster? * Remember to download substrate * Nightly for cargo fmt * Standardise CI names * fix clippy complaints * Ensure docs are valid and export publicly accessible types * all-targets clippy, and fix additional lint errors * newline in ci file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the CI from Soketto/Desub to run here. Main changes: