Rebuild test-runtime if substrate binary is updated
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Dec 10, 2021
ascjones
approved these changes
Dec 10, 2021
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
* Re-run test-runtime build script if the substrate binary changes * cargo fmt * Can => Cannot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, one could update the substrate binary on their PATH, and the test-runtime would not rebuild in response to this, leading to a potentially out of date runtime being used (the fix was to tweak
test-runtime/build.rsto force a rebuild).This resolves the path to the substrate binary and tells cargo to keep an eye on that, too.
Tested by
touching the substrate binary in use, which then caused a rebuild (and otherwise it would not rebuild).Closes #358