Implement pre_dispatch for SignedExtensions
#370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Dec 14, 2021
niklasad1
reviewed
Dec 14, 2021
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
niklasad1
approved these changes
Dec 14, 2021
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
* Explicitly specify master branch for sp-keyring dev dependency * Implement pre_dispatch for `SignedExtension`s * Update macro/Cargo.toml Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com> Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre_dispatchis a new method on theSignedExtensiontrait from substrate. We don't care about this internal implementation detail on thesubxtside, but we require this trait to be implemented because we are using theSignedPayloadandUncheckedExtrinsictypes fromsp_runtime.The other option is of course to define our own local types and traits to remove this direct coupling, but that need some careful consideration.
In the meantime this makes things compile and continue working against the
substratemaster branch.This also fixes an issue with duplicate substrate dependencies.