Use released substrate dependencies #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
commented
Dec 20, 2021
| @@ -144,7 +141,6 @@ impl RuntimeError { | |||
| DispatchError::CannotLookup => Ok(Self::CannotLookup), | |||
| DispatchError::ConsumerRemaining => Ok(Self::ConsumerRemaining), | |||
| DispatchError::NoProviders => Ok(Self::NoProviders), | |||
| DispatchError::TooManyConsumers => Ok(Self::TooManyConsumers), | |||
There was a problem hiding this comment.
We may want to parameterize DispatchError and allow the definition in the metadata to be used, in case of such a mismatch in the DispatchError type between the target node and the released version of sp_runtime
18 tasks
niklasad1
reviewed
Jan 17, 2022
macro/Cargo.toml
Outdated
| @@ -33,5 +33,4 @@ subxt-codegen = { version = "0.2.0", path = "../codegen" } | |||
| pretty_assertions = "0.6.1" | |||
| subxt = { path = ".." } | |||
| trybuild = "1.0.38" | |||
|
|
|||
| sp-keyring = { git = "https://github.com/paritytech/substrate/", branch = "master" } | |||
| sp-keyring = { version = "4.0.0" } | |||
There was a problem hiding this comment.
Suggested change
| sp-keyring = { version = "4.0.0" } | |
| sp-keyring = "4.0.0" |
There was a problem hiding this comment.
Ooh good point :) I'll fix both of those!
niklasad1
approved these changes
Jan 17, 2022
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
* WIP update dependencies to crates versions * Use released versions of sp-version and sp-arithmetic * Attempt to align version of sp-keyring used to correspond to 4.0.0 releases. No luck but closer * sp-keyring 4.0.0 * also sp-keyring 4.0.0 for macro crate * simplify cargo.tomls Co-authored-by: James Wilson <james@jsdw.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use substrate crates from
crates.io, which will allow us to do a release of this crate.todo
sp-keyringwhich is still at an old version oncrates.io. It's a dev dependency but it depends onsp-coreandsp-runtime, so brings in conflicting versions which causes the tests to not compile.DispatchErrorfrom the metadata, instead of the statically defined type fromsp_runtime, in case the target node has a differentDispatchErrordefinition. (in progress in Use the generated DispatchError instead of the hardcoded Substrate one #394; I don't think it needs to block this version bump PR from merging)