Update release documentation with dry-run #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
reviewed
Feb 4, 2022
RELEASING.md
Outdated
Comment on lines
54
to
60
| (cd codegen && cargo publish --dry-run) && \ | ||
| sleep 10 && \ | ||
| (cd macro && cargo publish --dry-run) && \ | ||
| sleep 10 && \ | ||
| (cd subxt && cargo publish --dry-run) && \ | ||
| sleep 10 && \ | ||
| (cd cli && cargo publish --dry-run); |
There was a problem hiding this comment.
Since it's a dry run we can get rid fo the sleep 10s too I suppose :)
jsdw
approved these changes
Feb 4, 2022
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
* releasing: Remove cargo-hack from doc Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * releasing: Add dry-run step Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> * releasing: Remove sleep from dry-run step Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PR (#434) the release process no longer relies on
cargo-hack.Remove the
cargo-hackfrom the documentation and add an extra dry-run step to ensure we can publish all crates at once.