Modify examples to work with latest substrate changes #440
Conversation
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
| for troubleshooting codegen as an alternative to `cargo expand`, and also provides the possibility of customizing the | ||
| generated code if the macro does not produce the desired API. e.g. |
There was a problem hiding this comment.
| for troubleshooting codegen as an alternative to `cargo expand`, and also provides the possibility of customizing the | |
| generated code if the macro does not produce the desired API. e.g. | |
| for troubleshooting codegen as an alternative to `cargo expand`, and also provides the possibility to customize the | |
| generated code if the macro does not produce the desired API. e.g. |
There was a problem hiding this comment.
Thanks! Will open a new PR, examples are working on master
| @@ -20,7 +20,7 @@ | |||
| runtime_metadata_path = "examples/polkadot_metadata.scale", | |||
| // We can add (certain) custom derives to the generated types by providing | |||
There was a problem hiding this comment.
Curious: do you happen to know what this "(certain)" means? Do we know which ones work and which don't?
There was a problem hiding this comment.
I haven't actually dug into this; I suspect we are limited by the derives on various types that are pointed at by the codegen types (eg sp_core::AccountId32 to use one example), so I think to find out we'd have to look through such types and find the common derives across them all.
There was a problem hiding this comment.
The subxt::Encode, subxt::Decode and Debug are already generated in polkadot.rs file.
Also std::Hash is problematic due to subxt::WrapperKeepOpaque<polkadot_runtime::Call> and PhantomDataSendSync. I guess I could address the Hash in a different PR.
| @@ -70,7 +70,7 @@ async fn simple_transfer() -> Result<(), Box<dyn std::error::Error>> { | |||
| balance_transfer.find_first_event::<polkadot::balances::events::Transfer>()?; | |||
|
|
|||
| if let Some(event) = transfer_event { | |||
| println!("Balance transfer success: value: {:?}", event.2); | |||
| println!("Balance transfer success: value: {:?}", event); | |||
There was a problem hiding this comment.
| println!("Balance transfer success: value: {:?}", event); | |
| println!("Balance transfer success. Value: {:?}", event); |
…but is it a "value" or an "event"?
There was a problem hiding this comment.
Mmm, it was a value but if we are printing out the entire event now by the looks of it, it's now just the Transfer event.
| @@ -119,7 +119,7 @@ async fn simple_transfer_separate_events() -> Result<(), Box<dyn std::error::Err | |||
| let transfer_event = | |||
| events.find_first_event::<polkadot::balances::events::Transfer>()?; | |||
| if let Some(event) = transfer_event { | |||
| println!("Balance transfer success: value: {:?}", event.2); | |||
| println!("Balance transfer success: value: {:?}", event); | |||
| @@ -20,7 +20,7 @@ | |||
| /// Generate by: | |||
| /// | |||
| /// - run `polkadot --dev --tmp` node locally | |||
| /// - `cargo run --release -p subxt-cli -- codegen | rustfmt --edition=2018 --emit=stdout > tests/integration/codegen/polkadot.rs` | |||
| /// - `cargo run --release -p subxt-cli -- codegen | rustfmt --edition=2018 --emit=stdout > subxt/tests/integration/codegen/polkadot.rs` | |||
There was a problem hiding this comment.
We're on edition 2021 I think. But also: do we really need that? I suspect just | rustfmt > subxt/…/… works too?
There was a problem hiding this comment.
I agree; I don't think either of the flags are needed actually (I always just rustfmt > outfile)
| @@ -20,7 +20,7 @@ | |||
| runtime_metadata_path = "examples/polkadot_metadata.scale", | |||
| // We can add (certain) custom derives to the generated types by providing | |||
| // a comma separated list to the below attribute. Most useful for adding `Clone`: | |||
| generated_type_derives = "Clone, Hash" | |||
| generated_type_derives = "Clone" | |||
There was a problem hiding this comment.
Interesting; did Hash not work? (I think I'd have more than one if possible just so that people can see how to add multiple derives (and adding just one is fairly obvious from that :))
|
(I re-ran the CI jobs – looks like crates.io was unreachable) |
|
Sorry about some of the file conflicts; I had a mess with the examples in the event subscription stuff! There are a couple of nice doc fixes in here; @lexnv would you like to push to get this merged or would you prefer to close it in favour of a new PR? |
|
Closed in favor of #449. |
This PR follows #439, and the CI should pull the latest substrate release.