Expose method to fetch nonce via Client
#451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
approved these changes
Feb 15, 2022
niklasad1
approved these changes
Feb 15, 2022
lexnv
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When manually managing an account's
nonceviaset_nonceandincrement_nonce, the current account nonce is not fetched by default but has to be manually initialized. The tricky thing is knowing what the current valid nonce is.This PR extracts a method which allows fetching the current value of an account's nonce via
Client, so we can initialize it withsigner.set_nonce.Possibly there is a nice API we could add which would perform this one-time initialization, but better to start with allowing it to be done explicitly. In any case it is useful to be able to query the current account nonce.