Replace log with tracing and record extrinsic info
#535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
approved these changes
May 12, 2022
jsdw
reviewed
May 12, 2022
| @@ -31,7 +32,7 @@ pub use sp_runtime::generic::Era; | |||
| /// "additional" parameters that are signed and used in transactions. | |||
| /// see [`BaseExtrinsicParams`] for an implementation that is compatible with | |||
| /// a Polkadot node. | |||
| pub trait ExtrinsicParams<T: Config> { | |||
| pub trait ExtrinsicParams<T: Config>: Debug { | |||
There was a problem hiding this comment.
Just wondering why this is wanted (and some of the other Debugs scattered about)?
There was a problem hiding this comment.
See comment below 👇
Chose to do on the trait itself rather than the method for a better error message.
ascjones
commented
May 12, 2022
| tracing::debug!( | ||
| "additional_and_extra_params: {:?}", | ||
| additional_and_extra_params | ||
| ); |
There was a problem hiding this comment.
@jsdw because of this
jsdw
approved these changes
May 12, 2022
dvdplm
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to
tracingcrate in line withjsonrpseeandsubstrate.Also add some extra logs for inspecting extrinsic construction.