Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deny unused crate dependencies #549

Merged
merged 2 commits into from
May 26, 2022
Merged

Deny unused crate dependencies #549

merged 2 commits into from
May 26, 2022

Conversation

ascjones
Copy link
Contributor

I haven't added it for the metadata crate since it wants to remove some benchmark target dev dependencies

niklasad1
niklasad1 approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jsdw
jsdw approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@jsdw jsdw merged commit ec23283 into master May 26, 2022
@jsdw jsdw deleted the aj/unused-crate-deps branch May 26, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ascjones @jsdw @niklasad1