Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error: RpcError with custom client error #694

Merged
merged 4 commits into from
Oct 20, 2022
Merged

error: RpcError with custom client error #694

merged 4 commits into from
Oct 20, 2022

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Oct 19, 2022

This PR extends the RpcError error to support two variants:

  • custom error originated from the RPC client (this is boxed to allow users to cast the error, without needlessly having the error generic)
  • custom string originated from subxt (ie, parsing parameters).

Closes #692.

@lexnv
error: RpcError with custom client error
8916d5d 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
jsdw reviewed Oct 19, 2022
View reviewed changes
subxt/src/error.rs Outdated Show resolved Hide resolved
@lexnv
error: Add SubscriptionDropped and panic on param errors
357725a 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
jsdw
jsdw reviewed Oct 19, 2022
View reviewed changes
subxt/src/rpc/rpc_client_t.rs Outdated Show resolved Hide resolved
@lexnv @jsdw
Update subxt/src/rpc/rpc_client_t.rs
07b5cdc 
Co-authored-by: James Wilson <james@jsdw.me>
@jsdw jsdw mentioned this pull request Oct 19, 2022
Closed
@lexnv
Apply rustfmt
01802b6 
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv mentioned this pull request Oct 19, 2022
Closed
jsdw
jsdw approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

niklasad1
niklasad1 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yepp, this will be useful 👍

@jsdw jsdw merged commit 6742fe0 into master Oct 20, 2022
@jsdw jsdw deleted the lexnv/692_box_rpc_err branch October 20, 2022 13:33
This was referenced Jan 18, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdw jsdw jsdw approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make RpcError generic
3 participants
@lexnv @jsdw @niklasad1