Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.lock to be part of git repo to have deterministics builds #701

Conversation

dzmitry-lahoda
Copy link

  • crates generate lock on build
  • we need commit not on crates yet
  • so making git to be same as crates dep
  • we add lock
  • which works well with nix
  • other options way harder to maintain

@niklasad1
Copy link
Member

niklasad1 commented Oct 27, 2022

Hey @dzmitry-lahoda

I don't understand what you are trying to accomplish by commiting Cargo.lock for the entire subxt repo.
I suppose committing Cargo.lock for subxt-cli would be required for "determinstic builds" because it's a binary crate?

The rest of crates are just libraries and committing Cargo.lock is just ignored then anyway...

@jsdw
Copy link
Collaborator

jsdw commented Oct 31, 2022

Since the workspace has both library crates (which don't want or need a cargo.lock) and binary crate which does, I'd propose for now that we follow https://github.com/BurntSushi/ripgrep and do save the cargo.lock.

we should also look at their release checklist and make sure we add a step to ours to ensure the lock file is updated each time we do a release.

@jsdw
Copy link
Collaborator

jsdw commented Nov 2, 2022

That all said, for my own sanity I'd like to generate and commit the lock file on our side (since it's so hard to review it for correctness) so I'll leave this PR open as a reminder and then open a new one with a lock file I've generated and close this :)

@jsdw
Copy link
Collaborator

jsdw commented Jan 18, 2023

We'll take care of this in #795 :)

@jsdw jsdw closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants