Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to scale-info 2.3 and fix errors #704

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Upgrade to scale-info 2.3 and fix errors #704

merged 1 commit into from
Nov 1, 2022

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Oct 31, 2022 •
edited
Loading

Okay so it turns out 2.3 did have some breaking changes after all, we didn't see it in substrate or ink because none of those used the FieldsBuilder::<NamedFields>::default() method.

This PR uses the idiomatic convenience methods Fields::named() and unnamed() instead.

@ascjones ascjones mentioned this pull request Oct 31, 2022
Merged
@jsdw jsdw merged commit 52d4762 into master Nov 1, 2022
@jsdw jsdw deleted the aj/scale-info-2.3 branch November 1, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ascjones @jsdw @niklasad1