Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement deserialize #773

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Implement deserialize #773

merged 2 commits into from
Jan 17, 2023

Conversation

simonsso
Copy link
Contributor

With some exposed functions AccountId32 can replace AccountId32 from substrate

jsdw
jsdw reviewed Jan 12, 2023
View reviewed changes
subxt/src/utils/account_id.rs Outdated Show resolved Hide resolved
@simonsso
Copy link
Contributor Author

@jsdw I have split this code into two parts now.

jsdw
jsdw approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@jsdw
Copy link
Collaborator

jsdw commented Jan 16, 2023

Merging master should fix any CI issues taht crop up :)

@jsdw jsdw merged commit c9f414f into paritytech:master Jan 17, 2023
@lx38
Copy link

lx38 commented Jan 28, 2023

How do you get a ss58check encoded format of the AccountId32? to_string() always encodes into 42 format. (not polkadot's).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonsso @jsdw @lx38 @lexnv