Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad signature when the extrinsic size is over 256 bytes #796

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix bad signature when the extrinsic size is over 256 bytes #796

merged 1 commit into from
Jan 19, 2023

Conversation

kvinwang
Copy link
Contributor

@kvinwang kvinwang commented Jan 19, 2023 •
edited
Loading

This is a bug introduced in #760.

jsdw
jsdw approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you! Happy to merge this and we should also add a test to cover this case

@jsdw jsdw merged commit 61878cc into paritytech:master Jan 19, 2023
@lexnv lexnv mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvinwang @jsdw @lexnv